Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Dave Chinner <dgc@kernel.org>
Cc: Henry Martin <bsdhenrymartin@gmail.com>,
	Carlos Maiolino <cem@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Darrick J . Wong" <djwong@kernel.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	David Hildenbrand <david@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Kairui Song <kasong@tencent.com>,
	Myeonghun Pak <mhun512@gmail.com>,
	Rafal Ostrowski <rafal.ostrowski@amd.com>,
	Likun Gao <Likun.Gao@amd.com>,
	James Clark <james.clark@linaro.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Kevin Brodsky <kevin.brodsky@arm.com>,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] xfs: fix out-of-bounds write from crafted btree root numrecs during log recovery
Date: Thu, 29 Oct 2026 08:37:06 -0600	[thread overview]
Message-ID: <87v76kmv3h.fsf@trenco.lwn.net> (raw)
In-Reply-To: <auKGlGJwOSZpioMd@dread>

Dave Chinner <dgc@kernel.org> writes:

> On Wed, Oct 28, 2026 at 04:43:37PM -0600, Jonathan Corbet wrote:
>> Dave Chinner <dgc@kernel.org> writes:
>> 
>> > Unless you know how to fix the discovered problem correctly, don't
>> > send what your LLM proposed for review. It will be garbage, and all
>> > that will do is annoy whoever has to review it. Just report the bug,
>> > let the subsystem developers fix it.
>> 
>> Just to be obnoxious...this runs counter to the advice we have in
>> Documentation/process/security-bugs.rst, where reporters are requested
>> to include a proposed fix as well.  It seems we're sending a bit of a
>> mixed message...
>
> These aren't security bugs. Bugs that result from maliciously
> corrupted filesystem images (i.e. fuzzed) are explicitly stated as
> not covered by the kernel security threat models. IOWs, they are
> just -bugs-, and bugs that just don't ever happen in the real world.

I wasn't arguing about the nature of the bug ... just noting the
disconnect with what I've heard from some maintainers, who say that
providing a patch helps in the identification of the problem, even if
the patch is not used.

Thanks,

jon

  parent reply	other threads:[~2026-10-29 14:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 15:17 [PATCH] xfs: fix out-of-bounds write from crafted btree root numrecs during log recovery Henry Martin
2026-10-28 22:26 ` Dave Chinner
2026-10-28 22:43   ` Jonathan Corbet
2026-10-28 23:34     ` Dave Chinner
2026-10-29  2:35       ` Theodore Tso
2026-10-29 21:39         ` Dave Chinner
2026-10-29 14:37       ` Jonathan Corbet [this message]
2026-10-29 20:59         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v76kmv3h.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=Likun.Gao@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=anshuman.khandual@arm.com \
    --cc=bsdhenrymartin@gmail.com \
    --cc=cem@kernel.org \
    --cc=david@kernel.org \
    --cc=dgc@kernel.org \
    --cc=djwong@kernel.org \
    --cc=james.clark@linaro.org \
    --cc=kasong@tencent.com \
    --cc=kevin.brodsky@arm.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mhun512@gmail.com \
    --cc=rafal.ostrowski@amd.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox