From: Chandan Babu R <chandan.babu@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/5] xfs: remove unused parameter from refcount code
Date: Wed, 20 Oct 2021 16:16:30 +0530 [thread overview]
Message-ID: <87v91sgeih.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <163466955467.2235671.4983293287731225085.stgit@magnolia>
On 20 Oct 2021 at 00:22, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The owner info parameter is always NULL, so get rid of the parameter.
Looks good to me.
Reviewed-by: Chandan Babu R <chandan.babu@oracle.com>
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/libxfs/xfs_refcount.c | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
>
> diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c
> index bb9e256f4970..327ba25e9e17 100644
> --- a/fs/xfs/libxfs/xfs_refcount.c
> +++ b/fs/xfs/libxfs/xfs_refcount.c
> @@ -918,8 +918,7 @@ xfs_refcount_adjust_extents(
> struct xfs_btree_cur *cur,
> xfs_agblock_t *agbno,
> xfs_extlen_t *aglen,
> - enum xfs_refc_adjust_op adj,
> - struct xfs_owner_info *oinfo)
> + enum xfs_refc_adjust_op adj)
> {
> struct xfs_refcount_irec ext, tmp;
> int error;
> @@ -977,7 +976,7 @@ xfs_refcount_adjust_extents(
> cur->bc_ag.pag->pag_agno,
> tmp.rc_startblock);
> xfs_free_extent_later(cur->bc_tp, fsbno,
> - tmp.rc_blockcount, oinfo);
> + tmp.rc_blockcount, NULL);
> }
>
> (*agbno) += tmp.rc_blockcount;
> @@ -1021,8 +1020,8 @@ xfs_refcount_adjust_extents(
> fsbno = XFS_AGB_TO_FSB(cur->bc_mp,
> cur->bc_ag.pag->pag_agno,
> ext.rc_startblock);
> - xfs_free_extent_later(cur->bc_tp, fsbno, ext.rc_blockcount,
> - oinfo);
> + xfs_free_extent_later(cur->bc_tp, fsbno,
> + ext.rc_blockcount, NULL);
> }
>
> skip:
> @@ -1050,8 +1049,7 @@ xfs_refcount_adjust(
> xfs_extlen_t aglen,
> xfs_agblock_t *new_agbno,
> xfs_extlen_t *new_aglen,
> - enum xfs_refc_adjust_op adj,
> - struct xfs_owner_info *oinfo)
> + enum xfs_refc_adjust_op adj)
> {
> bool shape_changed;
> int shape_changes = 0;
> @@ -1094,8 +1092,7 @@ xfs_refcount_adjust(
> cur->bc_ag.refc.shape_changes++;
>
> /* Now that we've taken care of the ends, adjust the middle extents */
> - error = xfs_refcount_adjust_extents(cur, new_agbno, new_aglen,
> - adj, oinfo);
> + error = xfs_refcount_adjust_extents(cur, new_agbno, new_aglen, adj);
> if (error)
> goto out_error;
>
> @@ -1190,12 +1187,12 @@ xfs_refcount_finish_one(
> switch (type) {
> case XFS_REFCOUNT_INCREASE:
> error = xfs_refcount_adjust(rcur, bno, blockcount, &new_agbno,
> - new_len, XFS_REFCOUNT_ADJUST_INCREASE, NULL);
> + new_len, XFS_REFCOUNT_ADJUST_INCREASE);
> *new_fsb = XFS_AGB_TO_FSB(mp, pag->pag_agno, new_agbno);
> break;
> case XFS_REFCOUNT_DECREASE:
> error = xfs_refcount_adjust(rcur, bno, blockcount, &new_agbno,
> - new_len, XFS_REFCOUNT_ADJUST_DECREASE, NULL);
> + new_len, XFS_REFCOUNT_ADJUST_DECREASE);
> *new_fsb = XFS_AGB_TO_FSB(mp, pag->pag_agno, new_agbno);
> break;
> case XFS_REFCOUNT_ALLOC_COW:
--
chandan
prev parent reply other threads:[~2021-10-20 10:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 18:52 [PATCHSET 0/5] xfs: use slab caches for deferred log items Darrick J. Wong
2021-10-19 18:52 ` [PATCH 1/5] xfs: compact deferred intent item structures Darrick J. Wong
2021-10-20 10:44 ` Chandan Babu R
2021-10-19 18:52 ` [PATCH 2/5] xfs: create slab caches for frequently-used deferred items Darrick J. Wong
2021-10-20 10:45 ` Chandan Babu R
2021-10-21 1:56 ` Darrick J. Wong
2021-10-19 18:52 ` [PATCH 3/5] xfs: rename xfs_bmap_add_free to xfs_free_extent_later Darrick J. Wong
2021-10-20 10:45 ` Chandan Babu R
2021-10-19 18:52 ` [PATCH 4/5] xfs: reduce the size of struct xfs_extent_free_item Darrick J. Wong
2021-10-20 10:46 ` Chandan Babu R
2021-10-19 18:52 ` [PATCH 5/5] xfs: remove unused parameter from refcount code Darrick J. Wong
2021-10-20 10:46 ` Chandan Babu R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v91sgeih.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox