Re: [PATCH] split xfs_ioc_xattr

Niv Sardi
2008-04-16T03:47:43Z

Christoph Hellwig <hch@lst.de> writes:

> On Mon, Apr 14, 2008 at 01:14:47PM +1000, Niv Sardi wrote:
>>
>>
>> Christoph Hellwig <hch@lst.de> writes:
>> > The three subcases of xfs_ioc_xattr don't share any semantics and almost
>> > no code, so split it into three separate helpers.
>> >
>> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> Looks good to me, aren't the likely() unlinkely() deprecated ? shouldn't
>> they be killed ?
>
> Why would they be deprecated?

just an impression I had from on of Dave's comment to one of my patches:
« Can we kill all the likely() crap out of here? Modern hardware
branch predictors are far better than static prediction hints. »

But it looks like a matter of taste…

I'll push it in.
--
Niv Sardi