public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* xfsprogs-6.10 breaks C++ compilation
@ 2024-08-27 21:09 Sam James
  2024-08-27 21:11 ` Sam James
  0 siblings, 1 reply; 2+ messages in thread
From: Sam James @ 2024-08-27 21:09 UTC (permalink / raw)
  To: linux-xfs@vger.kernel.org

Hi!

Forwarding a downstream report from https://bugs.gentoo.org/938569.

xfs_fs.h's xfs_getparents_next_rec relies on an implicit void*-to-T*
cast which is legal in C, but not C++.

It fails like so when a C++ project tries to use the header:
```
/usr/include/xfs/xfs_fs.h: In function 'xfs_getparents_rec* xfs_getparents_next_rec(xfs_getparents*, xfs_getparents_rec*)':
/usr/include/xfs/xfs_fs.h:915:16: error: invalid conversion from 'void*' to 'xfs_getparents_rec*' [-fpermissive]
  915 |         return next;
      |                ^~~~
      |                |
      |                void*

```

It came up when building libktorrent.

thanks,
sam

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: xfsprogs-6.10 breaks C++ compilation
  2024-08-27 21:09 xfsprogs-6.10 breaks C++ compilation Sam James
@ 2024-08-27 21:11 ` Sam James
  0 siblings, 0 replies; 2+ messages in thread
From: Sam James @ 2024-08-27 21:11 UTC (permalink / raw)
  To: sam; +Cc: linux-xfs

nevermind, I see Matt's filed it at
https://bugzilla.kernel.org/show_bug.cgi?id=219203.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-27 21:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-27 21:09 xfsprogs-6.10 breaks C++ compilation Sam James
2024-08-27 21:11 ` Sam James

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox