From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <david@fromorbit.com>, Zorro Lang <zlang@redhat.com>,
linux-xfs@vger.kernel.org,
Mike Christie <michael.christie@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [6.5-rc5 regression] core dump hangs (was Re: [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+)
Date: Mon, 12 Jun 2023 12:11:19 -0500 [thread overview]
Message-ID: <87wn08ppvs.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <CAHk-=wh0hrFjcU5C8uHvLBThrT5vQsFHb7Jk6HRP3LAJqdNx1A@mail.gmail.com> (Linus Torvalds's message of "Mon, 12 Jun 2023 09:57:51 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, Jun 12, 2023 at 9:45 AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> You snipped the suspicion in my reply on why that exists, to avoid
>> io_wq_worker_sleeping() triggering.
>
> I'm not seeing why triggering io_wq_worker_sleeping() should even be a
> problem in the first place.
>
> I suspect that is entirely historical too, and has to do with how it
> used to do that
>
> struct io_worker *worker = kthread_data(tsk);
> struct io_wqe *wqe = worker->wqe;
>
> back in the bad old days of kthreads.
>
> But yeah, I don't know that code.
If it is a problem it looks like the thread shutdown can clear
"worker->flags & IO_WORKER_F_UP" rather than
"current->flags & PF_IO_WORKER".
I don't see how it makes sense for the load balancing logic for
a per-process thread pool to be running at that point.
Eric
next prev parent reply other threads:[~2023-06-12 17:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 12:48 [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+ Zorro Lang
2023-06-11 13:40 ` Zorro Lang
2023-06-11 23:01 ` Dave Chinner
2023-06-12 1:51 ` Darrick J. Wong
2023-06-12 2:21 ` [6.5-rc5 regression] core dump hangs (was Re: [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+) Dave Chinner
2023-06-12 3:14 ` Linus Torvalds
2023-06-12 5:16 ` Dave Chinner
2023-06-12 5:34 ` Linus Torvalds
2023-06-12 5:49 ` Dave Chinner
2023-06-12 6:11 ` Linus Torvalds
2023-06-12 8:45 ` Eric W. Biederman
2023-06-12 9:30 ` Zorro Lang
2023-06-12 11:27 ` Dave Chinner
2023-06-12 6:36 ` Zorro Lang
2023-06-12 15:36 ` Darrick J. Wong
2023-06-12 15:52 ` Eric W. Biederman
2023-06-12 15:56 ` Linus Torvalds
2023-06-12 16:27 ` Jens Axboe
2023-06-12 16:38 ` Jens Axboe
2023-06-12 16:42 ` Linus Torvalds
2023-06-12 16:45 ` Jens Axboe
2023-06-12 16:57 ` Linus Torvalds
2023-06-12 17:11 ` Eric W. Biederman [this message]
2023-06-12 17:30 ` Jens Axboe
2023-06-12 17:29 ` Jens Axboe
2023-06-12 17:51 ` Linus Torvalds
2023-06-12 17:53 ` Jens Axboe
2023-06-12 17:56 ` Linus Torvalds
2023-06-12 18:34 ` Linus Torvalds
2023-06-12 23:33 ` Dave Chinner
2023-06-12 16:45 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn08ppvs.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox