public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Dave Chinner <david@fromorbit.com>,
	Brian Foster <bfoster@redhat.com>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Ojaswin Mujoo <ojaswin@linux.ibm.com>,
	Disha Goel <disgoel@linux.ibm.com>
Subject: Re: [PATCHv9 1/6] iomap: Rename iomap_page to iomap_folio_state and others
Date: Mon, 12 Jun 2023 14:49:50 +0530	[thread overview]
Message-ID: <87wn09ghqh.fsf@doe.com> (raw)
In-Reply-To: <ZIa51URaIVjjG35D@infradead.org>

Christoph Hellwig <hch@infradead.org> writes:

> On Sun, Jun 11, 2023 at 11:21:48PM -0700, Christoph Hellwig wrote:
>> Looks good:
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

>
> Actually, coming back to this:
>
> -to_iomap_page(struct folio *folio)
> +static inline struct iomap_folio_state *iomap_get_ifs
>
> I find the to_* naming much more descriptive for derving the
> private data.  get tends to imply grabbing a refcount.

Not always. That would be iomap_ifs_get(ifs)/iomap_ifs_put(ifs).

See this -

static inline void *folio_get_private(struct folio *folio)
{
	return folio->private;
}

So, is it ok if we hear from others too on iomap_get_ifs() function
name?

-ritesh

  reply	other threads:[~2023-06-12  9:27 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10 11:39 [PATCHv9 0/6] iomap: Add support for per-block dirty state to improve write performance Ritesh Harjani (IBM)
2023-06-10 11:39 ` [PATCHv9 1/6] iomap: Rename iomap_page to iomap_folio_state and others Ritesh Harjani (IBM)
2023-06-12  6:21   ` Christoph Hellwig
2023-06-12  6:23     ` Christoph Hellwig
2023-06-12  9:19       ` Ritesh Harjani [this message]
2023-06-12 15:05         ` Darrick J. Wong
2023-06-12 15:08           ` Matthew Wilcox
2023-06-12 15:59             ` Darrick J. Wong
2023-06-12 17:43               ` Ritesh Harjani
2023-06-12 17:54                 ` Matthew Wilcox
2023-06-13  5:05             ` Christoph Hellwig
2023-06-10 11:39 ` [PATCHv9 2/6] iomap: Drop ifs argument from iomap_set_range_uptodate() Ritesh Harjani (IBM)
2023-06-12  6:24   ` Christoph Hellwig
2023-06-10 11:39 ` [PATCHv9 3/6] iomap: Add some uptodate state handling helpers for ifs state bitmap Ritesh Harjani (IBM)
2023-06-12  6:25   ` Christoph Hellwig
2023-06-12  9:14     ` Ritesh Harjani
2023-06-12 12:54     ` Andreas Gruenbacher
2023-06-12 15:18       ` Ritesh Harjani
2023-06-12 15:24         ` Matthew Wilcox
2023-06-12 15:33           ` Ritesh Harjani
2023-06-12 15:57           ` Andreas Gruenbacher
2023-06-12 16:10             ` Darrick J. Wong
2023-06-12 17:54               ` Ritesh Harjani
2023-06-12 12:40   ` Andreas Gruenbacher
2023-06-12 15:30     ` Ritesh Harjani
2023-06-12 16:14       ` Andreas Grünbacher
2023-06-12 16:16       ` Darrick J. Wong
2023-06-12 16:19         ` Andreas Gruenbacher
2023-06-12 17:57         ` Ritesh Harjani
2023-06-10 11:39 ` [PATCHv9 4/6] iomap: Refactor iomap_write_delalloc_punch() function out Ritesh Harjani (IBM)
2023-06-12  6:25   ` Christoph Hellwig
2023-06-12  9:01     ` Ritesh Harjani
2023-06-12 13:22   ` Matthew Wilcox
2023-06-12 14:03     ` Ritesh Harjani
2023-06-12 14:19       ` Matthew Wilcox
2023-06-12 13:56   ` Pankaj Raghav
2023-06-12 14:55     ` Ritesh Harjani
2023-06-10 11:39 ` [PATCHv9 5/6] iomap: Allocate ifs in ->write_begin() early Ritesh Harjani (IBM)
2023-06-10 11:39 ` [PATCHv9 6/6] iomap: Add per-block dirty state tracking to improve performance Ritesh Harjani (IBM)
2023-06-12  6:30   ` Christoph Hellwig
2023-06-12  9:00     ` Ritesh Harjani
2023-06-12 16:27   ` Matthew Wilcox
2023-06-15 15:03 ` [PATCHv9 0/6] iomap: Add support for per-block dirty state to improve write performance Ritesh Harjani
2023-06-15 16:12   ` Ritesh Harjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn09ghqh.fsf@doe.com \
    --to=ritesh.list@gmail.com \
    --cc=agruenba@redhat.com \
    --cc=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=disgoel@linux.ibm.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox