From: Dmitry Monakhov <dmonakhov@openvz.org>
To: Theodore Tso <tytso@mit.edu>, Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, hch@lst.de,
aelder@sgi.com
Subject: Re: [PATCH 6/8] xfstests: add fiemap operation to fsstress
Date: Thu, 03 Nov 2011 15:04:17 +0400 [thread overview]
Message-ID: <87wrbhxya6.fsf@dmbot.sw.ru> (raw)
In-Reply-To: <FA2EDC7F-92EC-449E-9FBC-B7955283DFAC@mit.edu>
On Thu, 3 Nov 2011 06:54:16 -0400, Theodore Tso <tytso@mit.edu> wrote:
>
> On Nov 2, 2011, at 3:55 PM, Christoph Hellwig wrote:
>
> > Alex, Eric, Dave - should we add new tests with the new operations
> > Dmitry added, or is adding new ops to the existing tests fine?
>
> One argument for adding new ops to existing tests is that it makes the run time of the entire test suite take longer. A QA pass is already taking quite a while, and it would be nice if we could keep xfstests as efficient as possible in terms of the maximum testing coverage per time spent running the test suite….
Yes, but regression test with explicit seed option should be
preserved. Number of such test is not too big, so it is reasonable to
hardcode set of operations in such tests and let all others use new features.
>
> -- Ted
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-03 11:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 0:48 [PATCH 0/8] xfstests: Bunch of new stress tests -v3 Dmitry Monakhov
2011-10-29 0:48 ` [PATCH 1/8] xfstests: fsstress dump inode info when possible Dmitry Monakhov
2011-10-29 0:48 ` [PATCH 2/8] xfstests: add different logging option to fsstress Dmitry Monakhov
2011-10-29 0:48 ` [PATCH 3/8] xfstests: fsstress should kill children tasks before exit Dmitry Monakhov
2011-10-29 0:48 ` [PATCH 4/8] xfstests: add fallocate support to fsstress Dmitry Monakhov
2011-10-29 0:48 ` [PATCH 5/8] xfstests: fsstress add FS_IOC_{SET, GET}FLAGS operations v2 Dmitry Monakhov
2011-10-29 0:48 ` [PATCH 6/8] xfstests: add fiemap operation to fsstress Dmitry Monakhov
2011-11-02 19:55 ` Christoph Hellwig
2011-11-03 9:34 ` Dmitry Monakhov
2011-11-03 12:14 ` Dmitry Monakhov
2011-11-03 12:28 ` Christoph Hellwig
2011-11-03 10:54 ` Theodore Tso
2011-11-03 11:04 ` Dmitry Monakhov [this message]
2011-11-03 16:05 ` Ted Ts'o
2011-10-29 0:48 ` [PATCH 7/8] xfstests: add a new test that runs fsstress under ENOSPC conditions Dmitry Monakhov
2011-11-02 19:53 ` Christoph Hellwig
2011-11-02 20:36 ` Dmitry Monakhov
2011-11-02 21:06 ` Christoph Hellwig
2011-10-29 0:48 ` [PATCH 8/8] xfstests: add a new quota " Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrbhxya6.fsf@dmbot.sw.ru \
--to=dmonakhov@openvz.org \
--cc=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox