From: Matteo Frigo <athena@fftw.org>
To: Dave Chinner <david@fromorbit.com>
Cc: dm-devel@redhat.com, xfs@oss.sgi.com
Subject: Re: [dm-devel] [BUG] pvmove corrupting XFS filesystems (was Re: [BUG] Internal error xfs_dir2_data_reada_verify)
Date: Tue, 26 Feb 2013 21:21:44 -0500 [thread overview]
Message-ID: <87y5eah4xz.fsf@fftw.org> (raw)
In-Reply-To: <20130227014900.GY5551@dastard> (Dave Chinner's message of "Wed, 27 Feb 2013 12:49:00 +1100")
Dave Chinner <david@fromorbit.com> writes:
> On Wed, Feb 27, 2013 at 01:04:14AM +0000, Alasdair G Kergon wrote:
>> (Quick pointers that might be relevant)
>>
>> EAGAIN, I'm not aware of dm itself returning that on the i/o path.
>
> Neither am I, but it's coming from somewhere in the IO path...
Well, I don't really know anything about this topic, so I may be
completely off the mark, but dm-raid1.c:mirror_map() does indeed return
EWOULDBLOCK, and EWOULDBLOCK is #define'd to be EAGAIN, so it seems to
me that dm-raid1 does indeed return EAGAIN for "rw == READA" (which I
assume is read-ahead) if the "region is not in-sync":
/*
* If region is not in-sync queue the bio.
*/
if (!r || (r == -EWOULDBLOCK)) {
if (rw == READA)
return -EWOULDBLOCK;
queue_bio(ms, bio, rw);
return DM_MAPIO_SUBMITTED;
}
Regards,
MF
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-27 2:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 0:47 [BUG] Internal error xfs_dir2_data_reada_verify Matteo Frigo
2013-02-26 4:40 ` [BUG] pvmove corrupting XFS filesystems (was Re: [BUG] Internal error xfs_dir2_data_reada_verify) Dave Chinner
2013-02-26 11:29 ` Matteo Frigo
2013-02-27 1:04 ` [dm-devel] " Alasdair G Kergon
2013-02-27 1:49 ` Dave Chinner
2013-02-27 2:21 ` Matteo Frigo [this message]
2013-02-27 2:29 ` Dave Chinner
2013-03-07 12:13 ` Matteo Frigo
2013-03-07 22:31 ` Dave Chinner
2013-03-07 22:50 ` Dave Chinner
2013-03-08 0:09 ` Matteo Frigo
2013-03-08 1:57 ` Dave Chinner
2013-03-08 11:38 ` Matteo Frigo
2013-02-27 15:07 ` Mike Snitzer
2013-02-27 15:10 ` Matteo Frigo
2013-02-27 23:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5eah4xz.fsf@fftw.org \
--to=athena@fftw.org \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox