From: Chandan Babu R <chandanbabu@kernel.org>
To: Chandan Babu R <chandanbabu@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Chandan Babu R <chandanrlinux@gmail.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PRBOMB] xfs: online repair patches for 6.9
Date: Mon, 26 Feb 2024 18:34:57 +0530 [thread overview]
Message-ID: <87zfvn4bnt.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <874jdv5qdh.fsf@debian-BULLSEYE-live-builder-AMD64>
On Mon, Feb 26, 2024 at 06:29:43 PM +0530, Chandan Babu R wrote:
> On Mon, Feb 26, 2024 at 02:26:46 AM -0800, Christoph Hellwig wrote:
>> On Fri, Feb 23, 2024 at 05:02:20PM -0800, Darrick J. Wong wrote:
>>> pc : kfree+0x54/0x2d8
>>> lr : xlog_cil_committed+0x11c/0x1d8 [xfs]
>>
>> This looks a lot like the bug I found in getbmap. Maybe try changing
>> that kfree to a kvfree?
>
> CIL context structures are allocated using kzalloc() (i.e. kmalloc() with
> __GFP_ZERO flag appended to flags argument). So kfree() should work right?
>
Sorry, I read Dave's email now. I had mistakenly thought that the call to
kfree() is the one which frees CIL context structure.
--
Chandan
prev parent reply other threads:[~2024-02-26 13:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 1:02 [PRBOMB] xfs: online repair patches for 6.9 Darrick J. Wong
2024-02-24 1:29 ` [GIT PULL 1/18] xfs: repair inode mode by scanning dirs Darrick J. Wong
2024-02-24 1:29 ` [GIT PULL 2/18] xfs: online repair of quota counters Darrick J. Wong
2024-02-24 1:29 ` [GIT PULL 3/18] xfs: online repair of file link counts Darrick J. Wong
2024-02-24 1:29 ` [GIT PULL 4/18] xfs: report corruption to the health trackers Darrick J. Wong
2024-02-24 1:30 ` [GIT PULL 5/18] xfs: indirect health reporting Darrick J. Wong
2024-02-24 1:30 ` [GIT PULL 6/18] xfs: online repair for fs summary counters Darrick J. Wong
2024-02-24 1:30 ` [GIT PULL 7/18] xfs: move btree geometry to ops struct Darrick J. Wong
2024-02-24 1:31 ` [GIT PULL 8/18] xfs: remove bc_btnum from btree cursors Darrick J. Wong
2024-02-24 1:31 ` [GIT PULL 9/18] xfs: btree check cleanups Darrick J. Wong
2024-02-24 1:31 ` [GIT PULL 10/18] xfs: btree readahead cleanups Darrick J. Wong
2024-02-24 1:31 ` [GIT PULL 11/18] xfs: buftarg cleanups Darrick J. Wong
2024-02-24 1:32 ` [GIT PULL 12/18] xfs: support in-memory btrees Darrick J. Wong
2024-02-24 1:32 ` [GIT PULL 13/18] xfs: online repair of rmap btrees Darrick J. Wong
2024-02-24 1:32 ` [GIT PULL 14/18] xfs: reduce refcount repair memory usage Darrick J. Wong
2024-02-24 1:32 ` [GIT PULL 15/18] xfs: bmap log intent cleanups Darrick J. Wong
2024-02-24 1:33 ` [GIT PULL 16/18] xfs: widen BUI formats to support realtime Darrick J. Wong
2024-02-24 1:33 ` [GIT PULL 17/18] xfs: support attrfork and unwritten BUIs Darrick J. Wong
2024-02-24 1:33 ` [GIT PULL 18/18] xfs: clean up symbolic link code Darrick J. Wong
2024-02-25 12:51 ` [PRBOMB] xfs: online repair patches for 6.9 Chandan Babu R
2024-02-26 10:26 ` Christoph Hellwig
2024-02-26 12:53 ` Dave Chinner
2024-02-26 12:59 ` Chandan Babu R
2024-02-26 13:04 ` Chandan Babu R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfvn4bnt.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandanbabu@kernel.org \
--cc=chandanrlinux@gmail.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox