public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tim Jödicke" <tim.joedicke@fh-worms.de>
To: xfs@oss.sgi.com
Subject: vfs dmapi handle generation problem
Date: Wed, 4 Jun 2008 15:55:04 +0200 (CEST)	[thread overview]
Message-ID: <8efbf9761cbff87b03e5326866cd914d.squirrel@webmailer.fh-worms.de> (raw)

hi,

i have a question about the dmapi support for xfs. in detail, it's about
the method "xfs_dm_inode_to_fh()". i tried to swap out this function to
vfs code and this is what it looks like now:

int
vfs_dm_inode_to_fh(struct inode *ip, dm_fid_t *dmfid, dm_fsid_t *dmfsid)
{
   dmfid->dm_fid_len = sizeof(dm_fid_t) - sizeof(dmfid->dm_fid_len);
   dmfid->dm_fid_pad = 0;
   memcpy(&dmfid->dm_fid_ino, &ip->i_ino, sizeof(dmfid->dm_fid_ino));
   dmfid->dm_fid_gen = ip->i_generation;

   *dmfsid = 11; // need generation system

   return 0;
}

don't be bothered by the fsid. ;) i use to have exactly one filesystem
registered und every time the fsid is used, it's 11. ;)

the problem is, that the generated handle is wrong. dm_handle_is_valid()
says, that the handle is valid, but i cannot set a disposition e.g. if i
get a handle via dm_path_to_fshandle() or dm_path_to_handle() (says the
handle is bad).

on the other hand, if i set a global disposition, receive the mount event
and get the fshandle from the message, the handle seems to be correct?

maybe you can give ma a hint? is something wrong with dm_inode_to_fh()?

thanks in advance,
tim

             reply	other threads:[~2008-06-04 13:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 13:55 Tim Jödicke [this message]
2008-06-04 15:16 ` vfs dmapi handle generation problem Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8efbf9761cbff87b03e5326866cd914d.squirrel@webmailer.fh-worms.de \
    --to=tim.joedicke@fh-worms.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox