Re: [PATCH v1 2/4] xfs: Update sb_frextents when lazy count is set

["Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>]

On Tue, 2026-02-17 at 21:54 -0800, Christoph Hellwig wrote:
> On Thu, Feb 12, 2026 at 07:31:45PM +0530, Nirjhar Roy (IBM) wrote:
> > Since sb_frextents is a lazy counter, update it when lazy count is set,
> > just like sb_icount, sb_ifree and sb_fdblocks.
> 
> The comment you removed explains why we need a different conditional
> for it, though.
So I just moved the comment and the updation of sb_frextents from outside of "if
(xfs_has_lazysbcount(mp)) {" to inside of it since sb_frextents is a also a lazy counter like the
sb_fdblocks, sb_ifree. The comment talks about using the positive version of freecounter i.e,
xfs_sum_freecounter(). Do you mean to say that the updation/sync of the sb_frextents should be
outside "if (xfs_has_lazysbcount(mp)) {" i.e, done irrespective of whether lazy count is set or not?
Please let me know if my understanding is wrong.
> 
> The commit message also doesn't explain at all:
Okay I can update the commit message
> 
>  - why you want to change it
How about "We should update all the free counters only if lazy count is set, else it will be
unnecessary work"?
>  - what the chane is (AFAICS just the conditional and not how it is
>    updated)
How about "Updating sb_frextents conditionally based on whether lazy count it set instead of doing
it unconditionally everytime when xfs_log_sb() is called"?
Does the above 2 look fine?
--NR