[PATCH v3 0/2] new: Improvements to new script

[PATCH v3 0/2] new: Improvements to new script

[Nirjhar Roy (IBM)]

This series adds a couple of improvements to the "new" script.
Patch-1/2 - Adds an optional name/email id parameter prompt to the new script while creating
 a new test file using the "new" file.
Patch 2/2 - Replace "status=0;exit 0" with _exit 0 in the skeleton file in "new".

[v2] -> v3
 - Modified the commit message to remove "email-id" from it (patch 1).

[v1] -> [v2]
 - Added RB of Zorro in patch 2 of [v1]
 - Modified the prompt message for entering the author name (patch 1 of [v1])
 - Removed patch 3 (Suggested by Zorro) of [v1]

[v1] https://lore.kernel.org/all/cover.1747123422.git.nirjhar.roy.lists@gmail.com/
[v2] https://lore.kernel.org/all/cover.1747306604.git.nirjhar.roy.lists@gmail.com/

Nirjhar Roy (IBM) (2):
  new: Add a new parameter (name) in the "new" script
  new: Replace "status=0; exit 0" with _exit 0

 new | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

--
2.34.1

[PATCH v3 1/2] new: Add a new parameter (name) in the "new" script

[Nirjhar Roy (IBM)]

This patch another optional interactive prompt to enter the
author name for each new test file that is created using
the "new" file.

The sample output looks like something like the following:

./new selftest
Next test id is 007
Append a name to the ID? Test name will be 007-$name. y,[n]:
Creating test file '007'
Add to group(s) [auto] (separate by space, ? for list): selftest quick
Enter <author_name>: Nirjhar Roy <nirjhar.roy.lists@gmail.com>
Creating skeletal script for you to edit ...
 done.

Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
---
 new | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/new b/new
index 6b50ffed..636648e2 100755
--- a/new
+++ b/new
@@ -136,6 +136,9 @@ else
 	check_groups "${new_groups[@]}" || exit 1
 fi
 
+read -p "Enter <author_name>: " -r
+author_name="${REPLY:=YOUR NAME HERE}"
+
 echo -n "Creating skeletal script for you to edit ..."
 
 year=`date +%Y`
@@ -143,7 +146,7 @@ year=`date +%Y`
 cat <<End-of-File >$tdir/$id
 #! /bin/bash
 # SPDX-License-Identifier: GPL-2.0
-# Copyright (c) $year YOUR NAME HERE.  All Rights Reserved.
+# Copyright (c) $year $author_name.  All Rights Reserved.
 #
 # FS QA Test $id
 #
-- 
2.34.1

Re: [PATCH v3 1/2] new: Add a new parameter (name) in the "new" script

[Zorro Lang]

On Mon, May 19, 2025 at 06:16:41AM +0000, Nirjhar Roy (IBM) wrote:
> This patch another optional interactive prompt to enter the
> author name for each new test file that is created using
> the "new" file.
> 
> The sample output looks like something like the following:
> 
> ./new selftest
> Next test id is 007
> Append a name to the ID? Test name will be 007-$name. y,[n]:
> Creating test file '007'
> Add to group(s) [auto] (separate by space, ? for list): selftest quick
> Enter <author_name>: Nirjhar Roy <nirjhar.roy.lists@gmail.com>
> Creating skeletal script for you to edit ...
>  done.
> 
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> ---
>  new | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/new b/new
> index 6b50ffed..636648e2 100755
> --- a/new
> +++ b/new
> @@ -136,6 +136,9 @@ else
>  	check_groups "${new_groups[@]}" || exit 1
>  fi
>  
> +read -p "Enter <author_name>: " -r
> +author_name="${REPLY:=YOUR NAME HERE}"
> +
>  echo -n "Creating skeletal script for you to edit ..."
>  
>  year=`date +%Y`
> @@ -143,7 +146,7 @@ year=`date +%Y`
>  cat <<End-of-File >$tdir/$id
>  #! /bin/bash
>  # SPDX-License-Identifier: GPL-2.0
> -# Copyright (c) $year YOUR NAME HERE.  All Rights Reserved.
> +# Copyright (c) $year $author_name.  All Rights Reserved.

Dave thought we shouldn't use "author_name" at here:
https://lore.kernel.org/fstests/aC509xXxgZJKKZVE@dread.disaster.area/

If you don't mind, I'll merge PATCH 2/2 this week. If you still hope to
have the 1/2, please consider the review point from Dave.

Thanks,
Zorro

>  #
>  # FS QA Test $id
>  #
> -- 
> 2.34.1
> 
> 

Re: [PATCH v3 1/2] new: Add a new parameter (name) in the "new" script

[Zorro Lang]

On Fri, May 23, 2025 at 10:03:43PM +0800, Zorro Lang wrote:
> On Mon, May 19, 2025 at 06:16:41AM +0000, Nirjhar Roy (IBM) wrote:
> > This patch another optional interactive prompt to enter the
> > author name for each new test file that is created using
> > the "new" file.
> > 
> > The sample output looks like something like the following:
> > 
> > ./new selftest
> > Next test id is 007
> > Append a name to the ID? Test name will be 007-$name. y,[n]:
> > Creating test file '007'
> > Add to group(s) [auto] (separate by space, ? for list): selftest quick
> > Enter <author_name>: Nirjhar Roy <nirjhar.roy.lists@gmail.com>
> > Creating skeletal script for you to edit ...
> >  done.
> > 
> > Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> > ---
> >  new | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/new b/new
> > index 6b50ffed..636648e2 100755
> > --- a/new
> > +++ b/new
> > @@ -136,6 +136,9 @@ else
> >  	check_groups "${new_groups[@]}" || exit 1
> >  fi
> >  
> > +read -p "Enter <author_name>: " -r
> > +author_name="${REPLY:=YOUR NAME HERE}"
> > +
> >  echo -n "Creating skeletal script for you to edit ..."
> >  
> >  year=`date +%Y`
> > @@ -143,7 +146,7 @@ year=`date +%Y`
> >  cat <<End-of-File >$tdir/$id
> >  #! /bin/bash
> >  # SPDX-License-Identifier: GPL-2.0
> > -# Copyright (c) $year YOUR NAME HERE.  All Rights Reserved.
> > +# Copyright (c) $year $author_name.  All Rights Reserved.
> 
> Dave thought we shouldn't use "author_name" at here:
> https://lore.kernel.org/fstests/aC509xXxgZJKKZVE@dread.disaster.area/
> 
> If you don't mind, I'll merge PATCH 2/2 this week. If you still hope to
> have the 1/2, please consider the review point from Dave.

Oh, sorry, you've sent a V4... Please ignore this one, I'm going to review
your V4.

> 
> Thanks,
> Zorro
> 
> >  #
> >  # FS QA Test $id
> >  #
> > -- 
> > 2.34.1
> > 
> > 

Re: [PATCH v3 1/2] new: Add a new parameter (name) in the "new" script

[Nirjhar Roy (IBM)]

On 5/23/25 19:42, Zorro Lang wrote:
> On Fri, May 23, 2025 at 10:03:43PM +0800, Zorro Lang wrote:
>> On Mon, May 19, 2025 at 06:16:41AM +0000, Nirjhar Roy (IBM) wrote:
>>> This patch another optional interactive prompt to enter the
>>> author name for each new test file that is created using
>>> the "new" file.
>>>
>>> The sample output looks like something like the following:
>>>
>>> ./new selftest
>>> Next test id is 007
>>> Append a name to the ID? Test name will be 007-$name. y,[n]:
>>> Creating test file '007'
>>> Add to group(s) [auto] (separate by space, ? for list): selftest quick
>>> Enter <author_name>: Nirjhar Roy <nirjhar.roy.lists@gmail.com>
>>> Creating skeletal script for you to edit ...
>>>   done.
>>>
>>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
>>> ---
>>>   new | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/new b/new
>>> index 6b50ffed..636648e2 100755
>>> --- a/new
>>> +++ b/new
>>> @@ -136,6 +136,9 @@ else
>>>   	check_groups "${new_groups[@]}" || exit 1
>>>   fi
>>>   
>>> +read -p "Enter <author_name>: " -r
>>> +author_name="${REPLY:=YOUR NAME HERE}"
>>> +
>>>   echo -n "Creating skeletal script for you to edit ..."
>>>   
>>>   year=`date +%Y`
>>> @@ -143,7 +146,7 @@ year=`date +%Y`
>>>   cat <<End-of-File >$tdir/$id
>>>   #! /bin/bash
>>>   # SPDX-License-Identifier: GPL-2.0
>>> -# Copyright (c) $year YOUR NAME HERE.  All Rights Reserved.
>>> +# Copyright (c) $year $author_name.  All Rights Reserved.
>> Dave thought we shouldn't use "author_name" at here:
>> https://lore.kernel.org/fstests/aC509xXxgZJKKZVE@dread.disaster.area/
>>
>> If you don't mind, I'll merge PATCH 2/2 this week. If you still hope to
>> have the 1/2, please consider the review point from Dave.
> Oh, sorry, you've sent a V4... Please ignore this one, I'm going to review
> your V4.

Yes, I have sent the v4 after addressing the review comments.

--NR

>
>> Thanks,
>> Zorro
>>
>>>   #
>>>   # FS QA Test $id
>>>   #
>>> -- 
>>> 2.34.1
>>>
>>>
-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore

[PATCH v3 2/2] new: Replace "status=0; exit 0" with _exit 0

[Nirjhar Roy (IBM)]

We should now start using _exit 0 for every new test
that we add.

Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
---
 new | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/new b/new
index 636648e2..dff69265 100755
--- a/new
+++ b/new
@@ -176,8 +176,7 @@ exit
 #echo "If failure, check \$seqres.full (this) and \$seqres.full.ok (reference)"
 
 # success, all done
-status=0
-exit
+_exit 0
 End-of-File
 
 sleep 2		# latency to read messages to this point
-- 
2.34.1