From: David Howells <dhowells@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: dhowells@redhat.com, linux-xfs@vger.kernel.org,
hch@infradead.org, amir73il@gmail.com, david@fromorbit.com,
fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] xfstests: Add first statx test [ver #10]
Date: Sat, 08 Apr 2017 22:07:55 +0100 [thread overview]
Message-ID: <9330.1491685675@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170408150812.GX22845@eguan.usersys.redhat.com>
Eryu Guan <eguan@redhat.com> wrote:
> Perhaps we should add a new autoconf rule in configure.ac and define
> HAVE_STATX if there's statx support, like what src/renameat2.c does?
The problem with that is that statx doesn't yet exist in glibc, so the tests
are going to be skipped. I can define __NR_statx only on arches for which we
have a number and make xfstests_statx() give ENOSYS if __NR_statx isn't
defined.
David
next prev parent reply other threads:[~2017-04-08 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 8:35 [PATCH 1/4] xfstests: Add an auxiliary program to create an AF_UNIX socket [ver #10] David Howells
2017-04-06 8:35 ` [PATCH 2/4] xfstests: Add first statx test " David Howells
2017-04-08 15:08 ` Eryu Guan
2017-04-08 21:05 ` David Howells
2017-04-08 21:07 ` David Howells [this message]
2017-04-09 7:47 ` Amir Goldstein
2017-04-09 19:39 ` Darrick J. Wong
2017-04-06 8:36 ` [PATCH 3/4] xfstests: Partially expand the documentation " David Howells
2017-04-06 8:36 ` [PATCH 4/4] xfstests: Check the stx_attributes settable by chattr " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9330.1491685675@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox