Re: [PATCH 2/2] xfs: fix backwards endian conversion in scrub

[Allison Henderson <allison.henderson@oracle.com>]

On 2/25/19 10:41 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Fix a backwards endian conversion of a constant.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>   fs/xfs/scrub/agheader.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/fs/xfs/scrub/agheader.c b/fs/xfs/scrub/agheader.c
> index 9d4e8293d37e..ddf06bfaa29d 100644
> --- a/fs/xfs/scrub/agheader.c
> +++ b/fs/xfs/scrub/agheader.c
> @@ -399,7 +399,7 @@ xchk_agf_xref_cntbt(
>   	if (!xchk_should_check_xref(sc, &error, &sc->sa.cnt_cur))
>   		return;
>   	if (!have) {
> -		if (agf->agf_freeblks != be32_to_cpu(0))
> +		if (agf->agf_freeblks != cpu_to_be32(0))
>   			xchk_block_xref_set_corrupt(sc, sc->sa.agf_bp);
>   		return;
>   	}
> 

Good catch.  I suppose there's not as much need to do the conversion if 
the value is 0?  But I think the call helps to make clear that the value 
is supposed to be in big endian.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>