From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, ritesh.list@gmail.com,
ojaswin@linux.ibm.com, djwong@kernel.org
Subject: Re: [PATCH v1] xfs: Fix the return value of xfs_rtcopy_summary()
Date: Wed, 17 Dec 2025 16:19:10 +0530 [thread overview]
Message-ID: <95693000-79b9-4c9f-a304-e4a18bd3a880@gmail.com> (raw)
In-Reply-To: <aUKFFyGAOEIclGTs@infradead.org>
On 12/17/25 15:55, Christoph Hellwig wrote:
> On Wed, Dec 17, 2025 at 11:07:42AM +0530, Nirjhar Roy (IBM) wrote:
>> xfs_rtcopy_summary() should return the appropriate error code
>> instead of always returning 0. The caller of this function which is
>> xfs_growfs_rt_bmblock() is already handling the error.
>>
>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> Fixes tag?
Fixes e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
I will send a v2 with the fixes tag and Darrick's RB. Thank you for
pointing this out.
--NR
>
--
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore
prev parent reply other threads:[~2025-12-17 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 5:37 [PATCH v1] xfs: Fix the return value of xfs_rtcopy_summary() Nirjhar Roy (IBM)
2025-12-17 5:57 ` Darrick J. Wong
2025-12-17 10:25 ` Christoph Hellwig
2025-12-17 10:49 ` Nirjhar Roy (IBM) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95693000-79b9-4c9f-a304-e4a18bd3a880@gmail.com \
--to=nirjhar.roy.lists@gmail.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox