From: Allison Henderson <allison.henderson@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v7 03/23] xfs: Add trans toggle to attr routines
Date: Wed, 13 Jun 2018 18:27:56 -0700 [thread overview]
Message-ID: <99077327-664e-8838-0ece-3c77b17068c6@oracle.com> (raw)
In-Reply-To: <20180613121136.GA65076@bfoster>
On 06/13/2018 05:11 AM, Brian Foster wrote:
> On Sat, Jun 09, 2018 at 10:04:48PM -0700, Allison Henderson wrote:
>> This patch adds a roll_trans parameter to all attribute routines.
>> Calling functions may pass true to roll transactions as normal,
>> or false to hold them. We will need this later for delayed
>> attribute operations.
>>
>> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
>> ---
>> fs/xfs/libxfs/xfs_attr.c | 165 ++++++++++++++++++++++++------------------
>> fs/xfs/libxfs/xfs_attr_leaf.c | 12 +--
>> fs/xfs/libxfs/xfs_attr_leaf.h | 10 ++-
>> 3 files changed, 108 insertions(+), 79 deletions(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
>> index 1524197..e8cb369 100644
>> --- a/fs/xfs/libxfs/xfs_attr.c
>> +++ b/fs/xfs/libxfs/xfs_attr.c
>> @@ -55,21 +55,21 @@
>> /*
>> * Internal routines when attribute list fits inside the inode.
>> */
>> -STATIC int xfs_attr_shortform_addname(xfs_da_args_t *args);
>> +STATIC int xfs_attr_shortform_addname(xfs_da_args_t *args, bool roll_trans);
>>
>> /*
>> * Internal routines when attribute list is one block.
>> */
>> STATIC int xfs_attr_leaf_get(xfs_da_args_t *args);
>> -STATIC int xfs_attr_leaf_addname(xfs_da_args_t *args);
>> -STATIC int xfs_attr_leaf_removename(xfs_da_args_t *args);
>> +STATIC int xfs_attr_leaf_addname(xfs_da_args_t *args, bool roll_trans);
>> +STATIC int xfs_attr_leaf_removename(xfs_da_args_t *args, bool roll_trans);
>>
>> /*
>> * Internal routines when attribute list is more than one block.
>> */
>> STATIC int xfs_attr_node_get(xfs_da_args_t *args);
>> -STATIC int xfs_attr_node_addname(xfs_da_args_t *args);
>> -STATIC int xfs_attr_node_removename(xfs_da_args_t *args);
>> +STATIC int xfs_attr_node_addname(xfs_da_args_t *args, bool roll_trans);
>> +STATIC int xfs_attr_node_removename(xfs_da_args_t *args, bool roll_trans);
>> STATIC int xfs_attr_fillstate(xfs_da_state_t *state);
>> STATIC int xfs_attr_refillstate(xfs_da_state_t *state);
>>
>> @@ -207,15 +207,16 @@ STATIC int
>> xfs_attr_try_sf_addname(
>> struct xfs_inode *dp,
>> struct xfs_da_args *args,
>> - int flags)
>> + int flags,
>> + bool roll_trans)
>> {
>>
>> struct xfs_mount *mp = dp->i_mount;
>> int error;
>> int err2;
>>
>> - error = xfs_attr_shortform_addname(args);
>> - if (error != -ENOSPC) {
>> + error = xfs_attr_shortform_addname(args, roll_trans);
>> + if (error != -ENOSPC && roll_trans) {
>
> Doesn't this change behavior beyond committing the transaction or not?
> E.g., we skip the time call that follows if !roll_trans. Would the
> !roll_trans caller know/care about that?
Oh ok, I think you're right, the time call may need to move upwards in
both cases you pointed out. I may not have this patch in the next set
though if I can work out a better solution. But thanks for the catch :-)
Allison
>
>> /*
>> * Commit the shortform mods, and we're done.
>> * NOTE: this is also the error path
>> @@ -335,7 +336,7 @@ xfs_attr_set(
>> * Try to add the attr to the attribute list in
>> * the inode.
>> */
>> - error = xfs_attr_try_sf_addname(dp, &args, flags);
>> + error = xfs_attr_try_sf_addname(dp, &args, flags, true);
>> if (error != -ENOSPC) {
>> xfs_iunlock(dp, XFS_ILOCK_EXCL);
>> return error;
>> @@ -374,9 +375,9 @@ xfs_attr_set(
>> }
>>
>> if (xfs_bmap_one_block(dp, XFS_ATTR_FORK))
>> - error = xfs_attr_leaf_addname(&args);
>> + error = xfs_attr_leaf_addname(&args, true);
>> else
>> - error = xfs_attr_node_addname(&args);
>> + error = xfs_attr_node_addname(&args, true);
>> if (error)
>> goto out;
>>
>> @@ -471,11 +472,11 @@ xfs_attr_remove(
>> error = -ENOATTR;
>> } else if (dp->i_d.di_aformat == XFS_DINODE_FMT_LOCAL) {
>> ASSERT(dp->i_afp->if_flags & XFS_IFINLINE);
>> - error = xfs_attr_shortform_remove(&args);
>> + error = xfs_attr_shortform_remove(&args, true);
>> } else if (xfs_bmap_one_block(dp, XFS_ATTR_FORK)) {
>> - error = xfs_attr_leaf_removename(&args);
>> + error = xfs_attr_leaf_removename(&args, true);
>> } else {
>> - error = xfs_attr_node_removename(&args);
>> + error = xfs_attr_node_removename(&args, true);
>> }
>>
>> if (error)
>> @@ -516,7 +517,7 @@ xfs_attr_remove(
>> * This is the external routine.
>> */
>> STATIC int
>> -xfs_attr_shortform_addname(xfs_da_args_t *args)
>> +xfs_attr_shortform_addname(xfs_da_args_t *args, bool roll_trans)
>> {
>> int newsize, forkoff, retval;
>>
>> @@ -528,7 +529,7 @@ xfs_attr_shortform_addname(xfs_da_args_t *args)
>> } else if (retval == -EEXIST) {
>> if (args->flags & ATTR_CREATE)
>> return retval;
>> - retval = xfs_attr_shortform_remove(args);
>> + retval = xfs_attr_shortform_remove(args, roll_trans);
>> ASSERT(retval == 0);
>> }
>>
>> @@ -543,7 +544,7 @@ xfs_attr_shortform_addname(xfs_da_args_t *args)
>> if (!forkoff)
>> return -ENOSPC;
>>
>> - xfs_attr_shortform_add(args, forkoff);
>> + xfs_attr_shortform_add(args, forkoff, roll_trans);
>> return 0;
>> }
>>
>> @@ -559,7 +560,7 @@ xfs_attr_shortform_addname(xfs_da_args_t *args)
>> * if bmap_one_block() says there is only one block (ie: no remote blks).
>> */
>> STATIC int
>> -xfs_attr_leaf_addname(xfs_da_args_t *args)
>> +xfs_attr_leaf_addname(xfs_da_args_t *args, bool roll_trans)
>> {
>> xfs_inode_t *dp;
>> struct xfs_buf *bp;
>> @@ -622,36 +623,42 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
>> * can manage its own transactions.
>> */
>> xfs_defer_init(args->dfops, args->firstblock);
>> - error = xfs_attr3_leaf_to_node(args);
>> + error = xfs_attr3_leaf_to_node(args, roll_trans);
>> if (error)
>> goto out_defer_cancel;
>> xfs_defer_ijoin(args->dfops, dp);
>> - error = xfs_defer_finish(&args->trans, args->dfops);
>> - if (error)
>> - goto out_defer_cancel;
>> + if (roll_trans) {
>> + error = xfs_defer_finish(&args->trans, args->dfops);
>> + if (error)
>> + goto out_defer_cancel;
>>
>> - /*
>> - * Commit the current trans (including the inode) and start
>> - * a new one.
>> - */
>> - error = xfs_trans_roll_inode(&args->trans, dp);
>> - if (error)
>> - return error;
>> + /*
>> + * Commit the current trans (including the inode) and
>> + * start a new one.
>> + */
>> + error = xfs_trans_roll_inode(&args->trans, dp);
>> + if (error)
>> + return error;
>> + }
>>
>> /*
>> * Fob the whole rest of the problem off on the Btree code.
>> */
>> - error = xfs_attr_node_addname(args);
>> + error = xfs_attr_node_addname(args, roll_trans);
>> +
>> return error;
>> }
>>
>> - /*
>> - * Commit the transaction that added the attr name so that
>> - * later routines can manage their own transactions.
>> - */
>> - error = xfs_trans_roll_inode(&args->trans, dp);
>> - if (error)
>> - return error;
>> +
>> + if (roll_trans) {
>> + /*
>> + * Commit the transaction that added the attr name so that
>> + * later routines can manage their own transactions.
>> + */
>> + error = xfs_trans_roll_inode(&args->trans, dp);
>> + if (error)
>> + return error;
>> + }
>>
>> /*
>> * If there was an out-of-line value, allocate the blocks we
>> @@ -709,9 +716,11 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
>> /*
>> * If the result is small enough, shrink it all into the inode.
>> */
>> - if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
>> + if ((forkoff = xfs_attr_shortform_allfit(bp, dp)) &&
>> + roll_trans) {
>
> Similar here (and one or two other places in the patch).. I haven't
> looked ahead at the follow on code, but it seems a bit strange for a
> "don't roll trans" flag to toggle attr fork behavior.
>
>> xfs_defer_init(args->dfops, args->firstblock);
>> - error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
>> + error = xfs_attr3_leaf_to_shortform(bp, args, forkoff,
>> + roll_trans);
>> /* bp is gone due to xfs_da_shrink_inode */
>> if (error)
>> goto out_defer_cancel;
>> @@ -745,7 +754,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
>> * if bmap_one_block() says there is only one block (ie: no remote blks).
>> */
>> STATIC int
>> -xfs_attr_leaf_removename(xfs_da_args_t *args)
>> +xfs_attr_leaf_removename(xfs_da_args_t *args, bool roll_trans)
>> {
>> xfs_inode_t *dp;
>> struct xfs_buf *bp;
>> @@ -774,15 +783,19 @@ xfs_attr_leaf_removename(xfs_da_args_t *args)
>> * If the result is small enough, shrink it all into the inode.
>> */
>> if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
>> - xfs_defer_init(args->dfops, args->firstblock);
>> - error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
>> + if (roll_trans)
>> + xfs_defer_init(args->dfops, args->firstblock);
>> + error = xfs_attr3_leaf_to_shortform(bp, args, forkoff,
>> + roll_trans);
>
> While here roll_trans seems to only control the transaction behavior.
> Hm?
>
> Brian
>
>> /* bp is gone due to xfs_da_shrink_inode */
>> if (error)
>> goto out_defer_cancel;
>> xfs_defer_ijoin(args->dfops, dp);
>> - error = xfs_defer_finish(&args->trans, args->dfops);
>> - if (error)
>> - goto out_defer_cancel;
>> + if (roll_trans) {
>> + error = xfs_defer_finish(&args->trans, args->dfops);
>> + if (error)
>> + goto out_defer_cancel;
>> + }
>> }
>> return 0;
>> out_defer_cancel:
>> @@ -837,7 +850,7 @@ xfs_attr_leaf_get(xfs_da_args_t *args)
>> * add a whole extra layer of confusion on top of that.
>> */
>> STATIC int
>> -xfs_attr_node_addname(xfs_da_args_t *args)
>> +xfs_attr_node_addname(xfs_da_args_t *args, bool roll_trans)
>> {
>> xfs_da_state_t *state;
>> xfs_da_state_blk_t *blk;
>> @@ -903,21 +916,24 @@ xfs_attr_node_addname(xfs_da_args_t *args)
>> xfs_da_state_free(state);
>> state = NULL;
>> xfs_defer_init(args->dfops, args->firstblock);
>> - error = xfs_attr3_leaf_to_node(args);
>> + error = xfs_attr3_leaf_to_node(args, roll_trans);
>> if (error)
>> goto out_defer_cancel;
>> xfs_defer_ijoin(args->dfops, dp);
>> - error = xfs_defer_finish(&args->trans, args->dfops);
>> - if (error)
>> - goto out_defer_cancel;
>> -
>> - /*
>> - * Commit the node conversion and start the next
>> - * trans in the chain.
>> - */
>> - error = xfs_trans_roll_inode(&args->trans, dp);
>> - if (error)
>> - goto out;
>> + if (roll_trans) {
>> + error = xfs_defer_finish(&args->trans,
>> + args->dfops);
>> + if (error)
>> + goto out_defer_cancel;
>> +
>> + /*
>> + * Commit the node conversion and start the next
>> + * trans in the chain.
>> + */
>> + error = xfs_trans_roll_inode(&args->trans, dp);
>> + if (error)
>> + goto out;
>> + }
>>
>> goto restart;
>> }
>> @@ -933,9 +949,11 @@ xfs_attr_node_addname(xfs_da_args_t *args)
>> if (error)
>> goto out_defer_cancel;
>> xfs_defer_ijoin(args->dfops, dp);
>> - error = xfs_defer_finish(&args->trans, args->dfops);
>> - if (error)
>> - goto out_defer_cancel;
>> + if (roll_trans) {
>> + error = xfs_defer_finish(&args->trans, args->dfops);
>> + if (error)
>> + goto out_defer_cancel;
>> + }
>> } else {
>> /*
>> * Addition succeeded, update Btree hashvals.
>> @@ -954,9 +972,11 @@ xfs_attr_node_addname(xfs_da_args_t *args)
>> * Commit the leaf addition or btree split and start the next
>> * trans in the chain.
>> */
>> - error = xfs_trans_roll_inode(&args->trans, dp);
>> - if (error)
>> - goto out;
>> + if (roll_trans) {
>> + error = xfs_trans_roll_inode(&args->trans, dp);
>> + if (error)
>> + goto out;
>> + }
>>
>> /*
>> * If there was an out-of-line value, allocate the blocks we
>> @@ -1031,9 +1051,12 @@ xfs_attr_node_addname(xfs_da_args_t *args)
>> if (error)
>> goto out_defer_cancel;
>> xfs_defer_ijoin(args->dfops, dp);
>> - error = xfs_defer_finish(&args->trans, args->dfops);
>> - if (error)
>> - goto out_defer_cancel;
>> + if (roll_trans) {
>> + error = xfs_defer_finish(&args->trans,
>> + args->dfops);
>> + if (error)
>> + goto out_defer_cancel;
>> + }
>> }
>>
>> /*
>> @@ -1072,7 +1095,7 @@ xfs_attr_node_addname(xfs_da_args_t *args)
>> * the root node (a special case of an intermediate node).
>> */
>> STATIC int
>> -xfs_attr_node_removename(xfs_da_args_t *args)
>> +xfs_attr_node_removename(xfs_da_args_t *args, bool roll_trans)
>> {
>> xfs_da_state_t *state;
>> xfs_da_state_blk_t *blk;
>> @@ -1181,9 +1204,11 @@ xfs_attr_node_removename(xfs_da_args_t *args)
>> if (error)
>> goto out;
>>
>> - if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
>> + if ((forkoff = xfs_attr_shortform_allfit(bp, dp)) &&
>> + roll_trans) {
>> xfs_defer_init(args->dfops, args->firstblock);
>> - error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
>> + error = xfs_attr3_leaf_to_shortform(bp, args, forkoff,
>> + roll_trans);
>> /* bp is gone due to xfs_da_shrink_inode */
>> if (error)
>> goto out_defer_cancel;
>> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
>> index 2135b8e..01935fe 100644
>> --- a/fs/xfs/libxfs/xfs_attr_leaf.c
>> +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
>> @@ -546,7 +546,7 @@ xfs_attr_shortform_create(xfs_da_args_t *args)
>> * Overflow from the inode has already been checked for.
>> */
>> void
>> -xfs_attr_shortform_add(xfs_da_args_t *args, int forkoff)
>> +xfs_attr_shortform_add(xfs_da_args_t *args, int forkoff, bool roll_trans)
>> {
>> xfs_attr_shortform_t *sf;
>> xfs_attr_sf_entry_t *sfe;
>> @@ -618,7 +618,7 @@ xfs_attr_fork_remove(
>> * Remove an attribute from the shortform attribute list structure.
>> */
>> int
>> -xfs_attr_shortform_remove(xfs_da_args_t *args)
>> +xfs_attr_shortform_remove(xfs_da_args_t *args, bool roll_trans)
>> {
>> xfs_attr_shortform_t *sf;
>> xfs_attr_sf_entry_t *sfe;
>> @@ -970,7 +970,8 @@ int
>> xfs_attr3_leaf_to_shortform(
>> struct xfs_buf *bp,
>> struct xfs_da_args *args,
>> - int forkoff)
>> + int forkoff,
>> + bool roll_trans)
>> {
>> struct xfs_attr_leafblock *leaf;
>> struct xfs_attr3_icleaf_hdr ichdr;
>> @@ -1039,7 +1040,7 @@ xfs_attr3_leaf_to_shortform(
>> nargs.valuelen = be16_to_cpu(name_loc->valuelen);
>> nargs.hashval = be32_to_cpu(entry->hashval);
>> nargs.flags = XFS_ATTR_NSP_ONDISK_TO_ARGS(entry->flags);
>> - xfs_attr_shortform_add(&nargs, forkoff);
>> + xfs_attr_shortform_add(&nargs, forkoff, roll_trans);
>> }
>> error = 0;
>>
>> @@ -1053,7 +1054,8 @@ xfs_attr3_leaf_to_shortform(
>> */
>> int
>> xfs_attr3_leaf_to_node(
>> - struct xfs_da_args *args)
>> + struct xfs_da_args *args,
>> + bool roll_trans)
>> {
>> struct xfs_attr_leafblock *leaf;
>> struct xfs_attr3_icleaf_hdr icleafhdr;
>> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.h b/fs/xfs/libxfs/xfs_attr_leaf.h
>> index 4da08af..79c236c 100644
>> --- a/fs/xfs/libxfs/xfs_attr_leaf.h
>> +++ b/fs/xfs/libxfs/xfs_attr_leaf.h
>> @@ -45,12 +45,13 @@ typedef struct xfs_attr_inactive_list {
>> * Internal routines when attribute fork size < XFS_LITINO(mp).
>> */
>> void xfs_attr_shortform_create(struct xfs_da_args *args);
>> -void xfs_attr_shortform_add(struct xfs_da_args *args, int forkoff);
>> +void xfs_attr_shortform_add(struct xfs_da_args *args, int forkoff,
>> + bool roll_trans);
>> int xfs_attr_shortform_lookup(struct xfs_da_args *args);
>> int xfs_attr_shortform_getvalue(struct xfs_da_args *args);
>> int xfs_attr_shortform_to_leaf(struct xfs_da_args *args,
>> struct xfs_buf **leaf_bp);
>> -int xfs_attr_shortform_remove(struct xfs_da_args *args);
>> +int xfs_attr_shortform_remove(struct xfs_da_args *args, bool roll_trans);
>> int xfs_attr_shortform_allfit(struct xfs_buf *bp, struct xfs_inode *dp);
>> int xfs_attr_shortform_bytesfit(struct xfs_inode *dp, int bytes);
>> xfs_failaddr_t xfs_attr_shortform_verify(struct xfs_inode *ip);
>> @@ -59,9 +60,10 @@ void xfs_attr_fork_remove(struct xfs_inode *ip, struct xfs_trans *tp);
>> /*
>> * Internal routines when attribute fork size == XFS_LBSIZE(mp).
>> */
>> -int xfs_attr3_leaf_to_node(struct xfs_da_args *args);
>> +int xfs_attr3_leaf_to_node(struct xfs_da_args *args, bool roll_trans);
>> int xfs_attr3_leaf_to_shortform(struct xfs_buf *bp,
>> - struct xfs_da_args *args, int forkoff);
>> + struct xfs_da_args *args, int forkoff,
>> + bool roll_trans);
>> int xfs_attr3_leaf_clearflag(struct xfs_da_args *args);
>> int xfs_attr3_leaf_setflag(struct xfs_da_args *args);
>> int xfs_attr3_leaf_flipflags(struct xfs_da_args *args);
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=LHZQ8fHvy6wDKXGTWcm97burZH5sQKHRDMaY1UthQxc&m=_Y5y0YcW5ilokzV2Epi1rHWmFcw8-yYhRjAmXTVZLHQ&s=9XINqnuINAJpBbkLnTfoAClgLIQI0eejUxkjnLdnC7g&e=
next prev parent reply other threads:[~2018-06-14 1:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 5:04 [PATCH v7 00/23] Parent Pointers v7 Allison Henderson
2018-06-10 5:04 ` [PATCH v7 01/23] xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.h Allison Henderson
2018-06-10 5:04 ` [PATCH v7 02/23] xfs: Add helper function xfs_attr_try_sf_addname Allison Henderson
2018-06-10 6:58 ` Amir Goldstein
2018-06-10 15:30 ` Allison Henderson
2018-06-10 5:04 ` [PATCH v7 03/23] xfs: Add trans toggle to attr routines Allison Henderson
2018-06-13 12:11 ` Brian Foster
2018-06-14 1:27 ` Allison Henderson [this message]
2018-06-10 5:04 ` [PATCH v7 04/23] xfs: Add attibute set and helper functions Allison Henderson
2018-06-10 5:04 ` [PATCH v7 05/23] xfs: Add attibute remove " Allison Henderson
2018-06-10 5:04 ` [PATCH v7 06/23] xfs: Set up infastructure for deferred attribute operations Allison Henderson
2018-06-13 15:18 ` Brian Foster
2018-06-14 1:28 ` Allison Henderson
2018-06-14 11:13 ` Brian Foster
2018-06-10 5:04 ` [PATCH v7 07/23] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2018-06-10 5:04 ` [PATCH v7 08/23] xfs: Remove all strlen calls in all xfs_attr_* functions for attr names Allison Henderson
2018-06-10 5:04 ` [PATCH v7 09/23] xfs: get directory offset when adding directory name Allison Henderson
2018-06-10 5:04 ` [PATCH v7 10/23] xfs: get directory offset when removing " Allison Henderson
2018-06-10 5:04 ` [PATCH v7 11/23] xfs: get directory offset when replacing a " Allison Henderson
2018-06-10 5:04 ` [PATCH v7 12/23] xfs: add parent pointer support to attribute code Allison Henderson
2018-06-10 5:04 ` [PATCH v7 13/23] xfs: define parent pointer xattr format Allison Henderson
2018-06-10 5:04 ` [PATCH v7 14/23] xfs: extent transaction reservations for parent attributes Allison Henderson
2018-06-10 5:05 ` [PATCH v7 15/23] xfs: Hold inode locks in xfs_ialloc Allison Henderson
2018-06-10 5:05 ` [PATCH v7 16/23] xfs: parent pointer attribute creation Allison Henderson
2018-06-10 5:05 ` [PATCH v7 17/23] xfs: add parent attributes to link Allison Henderson
2018-06-10 5:05 ` [PATCH v7 18/23] xfs: remove parent pointers in unlink Allison Henderson
2018-06-10 5:05 ` [PATCH v7 19/23] xfs: Add parent pointers to rename Allison Henderson
2018-06-10 13:39 ` Amir Goldstein
2018-06-10 17:34 ` Allison Henderson
2018-06-10 5:05 ` [PATCH v7 20/23] xfs: Add the parent pointer support to the superblock version 5 Allison Henderson
2018-06-10 5:05 ` [PATCH v7 21/23] xfs: Add helper function xfs_attr_list_context_init Allison Henderson
2018-06-10 5:05 ` [PATCH v7 22/23] xfs: Add parent pointer ioctl Allison Henderson
2018-06-10 5:05 ` [PATCH v7 23/23] xfs: Add delayed attributes error tag Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99077327-664e-8838-0ece-3c77b17068c6@oracle.com \
--to=allison.henderson@oracle.com \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).