From: Joe Perches <joe@perches.com>
To: Dave Chinner <david@fromorbit.com>, hmsjwzb <weizhefix@gmail.com>
Cc: darrick.wong@oracle.com, linux-xfs@vger.kernel.org,
linux-kerticrnel@vger.kernel.org
Subject: Re: [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c
Date: Sun, 11 Nov 2018 19:04:17 -0800 [thread overview]
Message-ID: <9b618d0aa0e7c0db78e3dcaf4d3ffe2e22b92a12.camel@perches.com> (raw)
In-Reply-To: <20181111233305.GL19305@dastard>
On Mon, 2018-11-12 at 10:33 +1100, Dave Chinner wrote:
> On Sun, Nov 11, 2018 at 08:36:03AM +0800, hmsjwzb wrote:
> > Possible unwrapped commit description (prefer a maximum 75 chars per line)
>
> NACK. Our preference is (and always has been) for comments to fill
> the entire 80 columns, just like the rest of the kernel. I have no
> idea who told you "75 columns is preferred" but they are wrong.
75 column is the preferred commit description length
as the general 'git log' style is indented a few chars.
This particular commit description is odd because the
comments in the code is being wrapped, not the commit
description.
Wei Zhe, can you please resubmit this with a better
commit description? Something like:
Wrap comments to 80 columns where appropriate.
next prev parent reply other threads:[~2018-11-12 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 0:36 [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c hmsjwzb
2018-11-11 0:54 ` Joe Perches
2018-11-11 23:33 ` Dave Chinner
2018-11-12 3:04 ` Joe Perches [this message]
2018-11-12 16:00 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b618d0aa0e7c0db78e3dcaf4d3ffe2e22b92a12.camel@perches.com \
--to=joe@perches.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-kerticrnel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=weizhefix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).