From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:46464 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387867AbfGWDIn (ORCPT ); Mon, 22 Jul 2019 23:08:43 -0400 Received: by mail-wr1-f67.google.com with SMTP id z1so41400589wru.13 for ; Mon, 22 Jul 2019 20:08:41 -0700 (PDT) Subject: Re: [PATCH 1/3] mm: Handle MADV_WILLNEED through vfs_fadvise() References: <20190711140012.1671-1-jack@suse.cz> <20190711140012.1671-2-jack@suse.cz> From: Boaz Harrosh Message-ID: <9da4596e-7de2-9ba1-0fc0-62bf83c39488@plexistor.com> Date: Tue, 23 Jul 2019 06:08:37 +0300 MIME-Version: 1.0 In-Reply-To: <20190711140012.1671-2-jack@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Jan Kara , linux-fsdevel@vger.kernel.org Cc: linux-mm@kvack.org, linux-xfs@vger.kernel.org, Amir Goldstein , Boaz Harrosh , stable@vger.kernel.org On 11/07/2019 17:00, Jan Kara wrote: > Currently handling of MADV_WILLNEED hint calls directly into readahead > code. Handle it by calling vfs_fadvise() instead so that filesystem can > use its ->fadvise() callback to acquire necessary locks or otherwise > prepare for the request. > > Suggested-by: Amir Goldstein > CC: stable@vger.kernel.org # Needed by "xfs: Fix stale data exposure > when readahead races with hole punch" > Signed-off-by: Jan Kara I had a similar patch for my needs. But did not drop the mmap_sem when calling into the FS. This one is much better. Reviewed-by: Boaz Harrosh I tested this patch, Works perfect for my needs. Thank you for this patch Boaz > --- > mm/madvise.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 628022e674a7..ae56d0ef337d 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -275,6 +276,7 @@ static long madvise_willneed(struct vm_area_struct *vma, > unsigned long start, unsigned long end) > { > struct file *file = vma->vm_file; > + loff_t offset; > > *prev = vma; > #ifdef CONFIG_SWAP > @@ -298,12 +300,20 @@ static long madvise_willneed(struct vm_area_struct *vma, > return 0; > } > > - start = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff; > - if (end > vma->vm_end) > - end = vma->vm_end; > - end = ((end - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff; > - > - force_page_cache_readahead(file->f_mapping, file, start, end - start); > + /* > + * Filesystem's fadvise may need to take various locks. We need to > + * explicitly grab a reference because the vma (and hence the > + * vma's reference to the file) can go away as soon as we drop > + * mmap_sem. > + */ > + *prev = NULL; /* tell sys_madvise we drop mmap_sem */ > + get_file(file); > + up_read(¤t->mm->mmap_sem); > + offset = (loff_t)(start - vma->vm_start) > + + ((loff_t)vma->vm_pgoff << PAGE_SHIFT); > + vfs_fadvise(file, offset, end - start, POSIX_FADV_WILLNEED); > + fput(file); > + down_read(¤t->mm->mmap_sem); > return 0; > } > >