From: Timothy Shimmin <tes@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: David Chinner <dgc@sgi.com>, xfs@oss.sgi.com
Subject: Re: xfs vs. lockdep
Date: Tue, 10 Oct 2006 14:55:33 +1000 [thread overview]
Message-ID: <B00614C05C5235594B24FDD6@boing.melbourne.sgi.com> (raw)
In-Reply-To: <452B0396.8060506@sandeen.net>
--On 9 October 2006 9:21:10 PM -0500 Eric Sandeen <sandeen@sandeen.net>
wrote:
>> This one rings a bell. I seem to recall multiple places where we destroy
>> without releasing the lock first.
>> And I vaguely remember Nathan mentioning that this was causing grief
>> for lockdep:)
>
>
> Ok, cool. Want a formal patch
Nope :)
> or you guys want to just free it up...
>
> /*
> * Free all memory associated with the inode.
> */
> + xfs_iunlock(ip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
> xfs_idestroy(ip);
>
> Thanks,
>
Thanks, I'll just check it in under Vlad's bug.
Cheers,
Tim.
next prev parent reply other threads:[~2006-10-10 4:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 17:58 xfs vs. lockdep Eric Sandeen
2006-10-09 23:36 ` Vlad Apostolov
2006-10-10 3:06 ` Eric Sandeen
2006-10-10 3:23 ` Vlad Apostolov
2006-10-10 0:47 ` David Chinner
2006-10-10 1:45 ` Timothy Shimmin
2006-10-10 2:21 ` Eric Sandeen
2006-10-10 4:55 ` Timothy Shimmin [this message]
2006-10-10 2:25 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B00614C05C5235594B24FDD6@boing.melbourne.sgi.com \
--to=tes@sgi.com \
--cc=dgc@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox