From: Brian Norris <briannorris@chromium.org>
To: sandeen@sandeen.net
Cc: sandeen@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfsprogs: don't include all xfs headers just for crc32
Date: Thu, 11 Oct 2018 16:08:48 -0700 [thread overview]
Message-ID: <CA+ASDXNermsMZsSOgCxJQkFrvXUG5ej+Ttfdav0tmGeGGqLKFA@mail.gmail.com> (raw)
In-Reply-To: <b6ee7861-3bf0-7192-d26e-5d57bcb10d19@sandeen.net>
On Thu, Oct 11, 2018 at 3:36 PM Eric Sandeen <sandeen@sandeen.net> wrote:
> Thanks. At this point I think you have a better grasp of what all the
> $FOO_FLAGS do than I do ;) It may be to keep things sorted
> and separate, but it also seemed useful to get a giant tangle of
> xfs header out of a non-xfs library file.
Yep! I'm happy with this patch. If I'm bothered enough, I can still
send another patch to sort out the flags further.
> I'm also on the fence about whether cross-compiling the self-check
> really even gains us much, given that it may be built or optimized
> completely differently from the code on the target arch ...
I don't have a whole lot of opinion here.
Regards,
Brian
prev parent reply other threads:[~2018-10-12 6:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:55 [PATCH] xfsprogs: don't include all xfs headers just for crc32 Eric Sandeen
2018-10-11 19:59 ` Brian Norris
2018-10-11 22:36 ` Eric Sandeen
2018-10-11 22:45 ` Darrick J. Wong
2018-10-17 17:18 ` Darrick J. Wong
2018-10-11 23:08 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+ASDXNermsMZsSOgCxJQkFrvXUG5ej+Ttfdav0tmGeGGqLKFA@mail.gmail.com \
--to=briannorris@chromium.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).