From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] build: define _DEFAULT_SOURCE if _BSD_SOURCE
Date: Thu, 2 Nov 2017 13:22:58 -0700 [thread overview]
Message-ID: <CAB=NE6XMwuNsu3YB71cxeKTEyiqME1TwFimT1q3o2LnGZR8zMA@mail.gmail.com> (raw)
In-Reply-To: <d1635f9c-dcc7-66fe-268d-2aece2d44ba8@sandeen.net>
On Thu, Nov 2, 2017 at 1:04 PM, Eric Sandeen <sandeen@sandeen.net> wrote:
> On 10/26/17 12:28 PM, Luis R. Rodriguez wrote:
>> ./configure will leave traces of a complaint on config.log when
>> _BSD_SOURCE is defined but not _DEFAULT_SOURCE. _BSD_SOURCE is
>> deprecated so if defining _BSD_SOURCE also define _DEFAULT_SOURCE.
>>
>> From config.log:
>> /usr/include/features.h:183:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
>
> Ok. Or perhaps a more clear rationale is the preadv(5) manpage
> itself:
>
> preadv(), pwritev():
> since glibc 2.19:
> _DEFAULT_SOURCE
> Glibc 2.19 and earlier:
> _BSD_SOURCE
>
> But this is just a feature test macro in a configure script.
>
> What about the code itself, how do we handle this when we
> actually use preadv() in the codebase?
Its not clear to me what the issue would be by defining this extra
_DEFAULT_SOURCE when _BSD_SOURCE is defined.
Luis
next prev parent reply other threads:[~2017-11-02 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 17:28 [PATCH] build: define _DEFAULT_SOURCE if _BSD_SOURCE Luis R. Rodriguez
2017-11-02 20:04 ` Eric Sandeen
2017-11-02 20:22 ` Luis R. Rodriguez [this message]
2017-11-02 22:51 ` Eric Sandeen
2017-11-02 22:59 ` Luis R. Rodriguez
2017-11-03 3:10 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB=NE6XMwuNsu3YB71cxeKTEyiqME1TwFimT1q3o2LnGZR8zMA@mail.gmail.com' \
--to=mcgrof@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).