From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f68.google.com ([209.85.166.68]:33528 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727332AbfCOAQ3 (ORCPT ); Thu, 14 Mar 2019 20:16:29 -0400 Received: by mail-io1-f68.google.com with SMTP id b6so6939776iog.0 for ; Thu, 14 Mar 2019 17:16:29 -0700 (PDT) MIME-Version: 1.0 References: <155259742281.31886.17157720770696604377.stgit@magnolia> <155259745436.31886.466306969009991047.stgit@magnolia> In-Reply-To: <155259745436.31886.466306969009991047.stgit@magnolia> From: Nathan Scott Date: Fri, 15 Mar 2019 11:16:18 +1100 Message-ID: Subject: Re: [PATCH 05/36] debian: don't bypass top level Makefile when building subdirs Content-Type: text/plain; charset="UTF-8" Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: "Sandeen, Eric" , xfs On Fri, Mar 15, 2019 at 8:04 AM Darrick J. Wong wrote: > > From: Darrick J. Wong > > The top level Makefile does some processing to set build environment > variables (Q and CHECK_CMD). debian/rules uses -C to build subdirs > directly, which bypases this feature of the top-level makefile, which > causes more build spew than necessary (because Q never gets set to quiet > the build). > > Since the top level makefile can be used to build the subdirs > debian/rules cares about, drop the -C and build subdirs via the top > level Makefile to quiet the build. > > Signed-off-by: Darrick J. Wong Neat. Reviewed-by: Nathan Scott cheers. -- Nathan