From: Andreas Gruenbacher <agruenba@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-xfs@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/3] vfs: Add page_cache_seek_hole_data helper
Date: Mon, 26 Jun 2017 12:51:29 +0200 [thread overview]
Message-ID: <CAHc6FU4FdeceDTZHDN4NtH2oA2Yq-XcmAceVaSJY3y2g40-w0g@mail.gmail.com> (raw)
In-Reply-To: <20170626104156.GA23149@infradead.org>
On Mon, Jun 26, 2017 at 12:41 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Jun 23, 2017 at 02:19:31AM +0200, Andreas Gruenbacher wrote:
>> Both ext4 and xfs implement seeking for the next hole or piece of data
>> in unwritten extents by scanning the page cache, and both versions share
>> the same bug when iterating the buffers of a page: the start offset into
>> the page isn't taken into account, so when a page fits more than two
>> filesystem blocks, things will go wrong. For example, on a filesystem
>> with a block size of 1k, the following command will fail:
>>
>> xfs_io -f -c "falloc 0 4k" \
>> -c "pwrite 1k 1k" \
>> -c "pwrite 3k 1k" \
>> -c "seek -a -r 0" foo
>
> Can you wire this up for xfstests, please?
I did:
https://marc.info/?l=fstests&m=149817668119033
Andreas
prev parent reply other threads:[~2017-06-26 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 0:19 [PATCH 1/3] vfs: Add page_cache_seek_hole_data helper Andreas Gruenbacher
2017-06-23 0:19 ` [PATCH 2/3] ext4: Switch to page_cache_seek_hole_data Andreas Gruenbacher
2017-06-23 0:19 ` [PATCH 3/3] xfs: " Andreas Gruenbacher
2017-06-26 10:41 ` [PATCH 1/3] vfs: Add page_cache_seek_hole_data helper Christoph Hellwig
2017-06-26 10:51 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU4FdeceDTZHDN4NtH2oA2Yq-XcmAceVaSJY3y2g40-w0g@mail.gmail.com \
--to=agruenba@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).