From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f180.google.com ([209.85.217.180]:36474 "EHLO mail-ua0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbdF3MMA (ORCPT ); Fri, 30 Jun 2017 08:12:00 -0400 Received: by mail-ua0-f180.google.com with SMTP id g40so74197000uaa.3 for ; Fri, 30 Jun 2017 05:11:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170629135420.21357-1-hch@lst.de> <20170629135420.21357-6-hch@lst.de> From: Andreas Gruenbacher Date: Fri, 30 Jun 2017 14:11:58 +0200 Message-ID: Subject: Re: [PATCH 5/5] ext4: Switch to iomap for SEEK_HOLE / SEEK_DATA Content-Type: text/plain; charset="UTF-8" Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Jan Kara , linux-fsdevel , linux-xfs@vger.kernel.org, linux-ext4 On Fri, Jun 30, 2017 at 1:51 PM, Andreas Gruenbacher wrote: > On Thu, Jun 29, 2017 at 3:54 PM, Christoph Hellwig wrote: >> Switch to the iomap_seek_hole and iomap_seek_data helpers for >> implementing lseek SEEK_HOLE / SEEK_DATA, and remove all the >> code that isn't needed any more. >> >> Note that with this patch ext4 will now always depend on the iomap >> code instead of only when CONFIG_DAX is enabled, and it requires >> adding a call into the extent status tree for iomap_begin as well >> to properly deal with delalloc extents. > > This breaks SEEK_HOLE / SEEK_DATA on filesystems with the inline_data feature. > > Also, ext4 no longer calls inode_lock or inode_lock_shared; that needs > to be added back for consistency between reading i_size and walking > the file extents. Same on xfs, btw. Thanks, Andreas