From: Linus Torvalds <torvalds@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: David Hildenbrand <david@redhat.com>,
Gavin Shan <gshan@redhat.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Zhenyu Zhang <zhenyzha@redhat.com>,
Linux XFS <linux-xfs@vger.kernel.org>,
Linux Filesystems Development <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shaoqin Huang <shahuang@redhat.com>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Endless calls to xas_split_alloc() due to corrupted xarray entry
Date: Wed, 19 Jun 2024 08:48:28 -0700 [thread overview]
Message-ID: <CAHk-=who82OKiXyTiCG3rUaiicO_OB9prVvZQBzg6GDGhdp+Ew@mail.gmail.com> (raw)
In-Reply-To: <ZnLrq4vJnfSNZ0wg@casper.infradead.org>
On Wed, 19 Jun 2024 at 07:31, Matthew Wilcox <willy@infradead.org> wrote:
>
> Actually, it's 11. We can't split an order-12 folio because we'd have
> to allocate two levels of radix tree, and I decided that was too much
> work. Also, I didn't know that ARM used order-13 PMD size at the time.
>
> I think this is the best fix (modulo s/12/11/).
Can we use some more descriptive thing than the magic constant 11 that
is clearly very subtle.
Is it "XA_CHUNK_SHIFT * 2 - 1"
IOW, something like
#define MAX_XAS_ORDER (XA_CHUNK_SHIFT * 2 - 1)
#define MAX_PAGECACHE_ORDER min(HPAGE_PMD_ORDER,12)
except for the non-TRANSPARENT_HUGEPAGE case where it currently does
#define MAX_PAGECACHE_ORDER 8
and I assume that "8" is just "random round value, smaller than 11"?
Linus
next prev parent reply other threads:[~2024-06-19 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 3:56 Endless calls to xas_split_alloc() due to corrupted xarray entry Zhenyu Zhang
[not found] ` <ZRFbIJH47RkQuDid@debian.me>
2023-09-25 15:12 ` Darrick J. Wong
2023-09-26 7:49 ` Zhenyu Zhang
2023-09-29 10:11 ` Gavin Shan
2023-09-29 19:17 ` Matthew Wilcox
2023-09-30 2:12 ` Gavin Shan
2024-06-19 9:45 ` David Hildenbrand
2024-06-19 14:31 ` Matthew Wilcox
2024-06-19 15:48 ` Linus Torvalds [this message]
2024-06-19 19:58 ` David Hildenbrand
2024-06-25 1:10 ` Gavin Shan
2024-06-19 20:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=who82OKiXyTiCG3rUaiicO_OB9prVvZQBzg6GDGhdp+Ew@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=chandan.babu@oracle.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=gshan@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=shahuang@redhat.com \
--cc=willy@infradead.org \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).