From: Amir Goldstein <amir73il@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v2] xfs_io: add command line option -M to run as multi threaded process
Date: Mon, 17 Oct 2016 09:15:43 +0300 [thread overview]
Message-ID: <CAOQ4uxhWDW7V4zakTNfaJpERWo1aa1-iOvxvaD2DqhwowpbxYA@mail.gmail.com> (raw)
In-Reply-To: <20161016212839.GB14023@dastard>
On Mon, Oct 17, 2016 at 12:28 AM, Dave Chinner <david@fromorbit.com> wrote:
> On Sun, Oct 16, 2016 at 11:55:11AM +0300, Amir Goldstein wrote:
>> xfs_io -M will start by spawning an idle thread.
>> The purpose of this idle thread is to test io from a multi threaded
>> process. With single threaded process, the file table is not shared
>> and file structs are not reference counted.
>
> I can see this option being confusing to those who do not understand
> what is actually be done here. i.e. we'll get complaints along the
> lines of "-M say xfs_io does multithreaded IO, but I only see IO
> from one thread!". Can we name this "-i" to mean "run an idle-loop",
> which will stop people trying to use it for something it doesn't do?
>
I considered those 2 options. I see what you are saying.
Will go for -i in v3.
>> --- a/io/Makefile
>> +++ b/io/Makefile
> ....
>> --- a/io/init.c
>> +++ b/io/init.c
> ....
>
> Missing a man page update to document this new option.
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
prev parent reply other threads:[~2016-10-17 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 8:55 [PATCH v2] xfs_io: add command line option -M to run as multi threaded process Amir Goldstein
2016-10-16 21:28 ` Dave Chinner
2016-10-17 6:15 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxhWDW7V4zakTNfaJpERWo1aa1-iOvxvaD2DqhwowpbxYA@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).