From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f67.google.com ([209.85.218.67]:44769 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbeCCCTR (ORCPT ); Fri, 2 Mar 2018 21:19:17 -0500 Received: by mail-oi0-f67.google.com with SMTP id b8so8413819oib.11 for ; Fri, 02 Mar 2018 18:19:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <151996281307.28483.12343847096989509127.stgit@dwillia2-desk3.amr.corp.intel.com> <20180302221020.GA30722@lst.de> <20180302225734.GE31240@lst.de> From: Dan Williams Date: Fri, 2 Mar 2018 18:19:16 -0800 Message-ID: Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes Content-Type: text/plain; charset="UTF-8" Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: linux-nvdimm , linux-xfs , "Darrick J. Wong" , KVM list , Haozhong Zhang , Jane Chu , Alexander Viro , Gerd Rausch , stable , Jan Kara , Michal Hocko , Andreas Dilger , Ross Zwisler , Matthew Wilcox , linux-fsdevel , Alex Williamson , Theodore Ts'o , Linux MM , Linux Kernel Mailing List On Fri, Mar 2, 2018 at 3:49 PM, Dan Williams wrote: > On Fri, Mar 2, 2018 at 2:57 PM, Christoph Hellwig wrote: >> On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: >>> They are indeed a hodge-podge. The problem is that the current >>> IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with >>> IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks >>> you propose for the next merge window. >> >> The only thing broken about IS_DAX are the code elimination games >> based on the CONFIG_* flags. Remove those and just add proper stubs >> for the dax routines and everything will be fine for now until we can >> kill that inode flag. >> >> IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't >> helping anyone. > > Ok, I'll take another shot at something suitable for 4.16, but without > these new helpers... I'll drop patches 2-11 for now, and just get the high priority fixes in for the next rc.