From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Jiang <dave.jiang@intel.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-xfs@vger.kernel.org, Linux MM <linux-mm@kvack.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Jan Kara <jack@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault
Date: Mon, 6 Feb 2017 08:24:48 -0800 [thread overview]
Message-ID: <CAPcyv4jHYR2-_SgD7a6ab5vWigYsDoSb7FZdTchP8Xg+BF-2yg@mail.gmail.com> (raw)
In-Reply-To: <20170206143648.GA461@infradead.org>
On Mon, Feb 6, 2017 at 6:36 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote:
>> Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has
>> been somewhat painful with getting the flags set and removed at the
>> correct locations. More than one kernel oops was introduced due to
>> difficulties of getting the placement correctly. Removing the flag
>> values and introducing an input parameter to huge_fault that indicates
>> the size of the page entry. This makes the code easier to trace and
>> should avoid the issues we see with the fault flags where removal of the
>> flag was necessary in the fallback paths.
>
> Why is this not in struct vm_fault?
Because this is easier to read and harder to get wrong. Same arguments
as getting rid of struct blk_dax_ctl.
> Also can be use this opportunity
> to fold ->huge_fault into ->fault?
Hmm, yes, just need a scheme to not attempt huge_faults on pte-only handlers.
next prev parent reply other threads:[~2017-02-06 16:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 21:31 [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault Dave Jiang
2017-02-03 21:47 ` Dan Williams
2017-02-03 22:56 ` kbuild test robot
2017-02-03 23:25 ` Dave Jiang
2017-02-03 23:26 ` Dan Williams
2017-02-04 0:00 ` Dan Williams
2017-02-04 0:07 ` Dave Jiang
2017-02-09 4:34 ` [kbuild-all] " Ye Xiaolong
2017-02-04 3:51 ` kbuild test robot
2017-02-06 8:51 ` Jan Kara
2017-02-06 14:36 ` Christoph Hellwig
2017-02-06 16:24 ` Dan Williams [this message]
2017-02-06 17:27 ` Christoph Hellwig
2017-02-06 17:30 ` Dan Williams
2017-02-07 8:44 ` Kirill A. Shutemov
2017-02-07 16:56 ` Dan Williams
2017-02-07 17:40 ` Kirill A. Shutemov
2017-02-07 18:08 ` Dan Williams
2017-02-08 8:41 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jHYR2-_SgD7a6ab5vWigYsDoSb7FZdTchP8Xg+BF-2yg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).