Re: [PATCH 1 of 2] Implement generic block_page_mkwrite() functionality

Nick Piggin
2007-02-08T02:34:30Z

Chris Mason wrote:
> On Thu, Feb 08, 2007 at 01:44:15AM +1100, David Chinner wrote:

>>So, do I need to grab the i_mutex here? Is that safe to do that in
>>the middle of a page fault? If we do race with a truncate and the
>>page is now beyond EOF, what am I supposed to return?
>
>
> Should it check to make sure the page is still in the address space
> after locking it?

Yes. If the page was truncated/invalidated, then you can just return
and the pagefault handler should notice that it has been removed from
the page tables.

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com