From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: [GIT PULL] XFS update for 2.6.29
Date: Sun, 11 Jan 2009 11:38:13 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0901111137410.30201@anakin> (raw)
In-Reply-To: <Pine.LNX.4.64.0901021056360.14380@anakin>
On Fri, 2 Jan 2009, Geert Uytterhoeven wrote:
> On Thu, 1 Jan 2009, Christoph Hellwig wrote:
> > On Thu, Jan 01, 2009 at 10:50:52AM +0100, Geert Uytterhoeven wrote:
> > > | fs/xfs/xfs_btree.c: In function 'xfs_btree_readahead_lblock':
> > > | fs/xfs/xfs_btree.c:736: warning: comparison is always true due to limited range of data type
> > > | fs/xfs/xfs_btree.c:741: warning: comparison is always true due to limited range of data type
> > >
> > > left/right = xfs_fsblock_t (32 or 64 bit), NULLDFSBNO = xfs_dfsbno_t (64 bit)
> >
> > Hmm, can't reproduce it here with CONFIG_LBD=n on x86, but the following
>
> x86-32 or -64?
>
> It may also depend on the compiler version. I have gcc version 4.1.2 20061115
> (prerelease) (Debian 4.1.1-21).
>
> > patch should fix it:
>
> Yep, the warning is good.
^^^^
gone
JFYI, the bug has entered Linus' tree. The fix hasn't.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-11 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 3:08 [GIT PULL] XFS update for 2.6.29 Lachlan McIlroy
2008-12-31 1:39 ` Linus Torvalds
2008-12-31 1:45 ` Lachlan McIlroy
2008-12-31 1:50 ` Linus Torvalds
2008-12-31 1:58 ` Lachlan McIlroy
2009-01-01 9:50 ` Geert Uytterhoeven
2009-01-01 17:03 ` Christoph Hellwig
2009-01-02 9:57 ` Geert Uytterhoeven
2009-01-02 9:58 ` Christoph Hellwig
2009-01-11 10:38 ` Geert Uytterhoeven [this message]
2009-01-11 15:45 ` Christoph Hellwig
[not found] ` <200812311419.10199.nickpiggin@yahoo.com.au>
2009-01-05 3:27 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0901111137410.30201@anakin \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox