Re: [PATCH 5/7] xfs: only walk the incore inode tree once per blockgc scan

Darrick J. Wong
2021-01-13T20:42:04Z

On Wed, Jan 13, 2021 at 04:06:32PM +0100, Christoph Hellwig wrote:
> On Mon, Jan 11, 2021 at 03:23:46PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Perform background block preallocation gc scans more efficiently by
> > walking the incore inode tree once.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
>
> Looks good. If you could find a way to avoid the forward declarations
> I'd be even more happy :)

They went away as a part of the massive rework stemming from Dave's
"simple" review comment in the previous series about moving the ENOSPC
retry loops into the quota reservation functions.

Granted, the double series has ballooned from 13 to 28 patches as I had
to clean up even more quota code... :(

--D

> Reviewed-by: Christoph Hellwig <hch@lst.de>