From: Leah Rumancik <leah.rumancik@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: zlang@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me, quwenruo.btrfs@gmx.com,
tytso@mit.edu
Subject: Re: [PATCH 01/14] check: generate section reports between tests
Date: Wed, 15 Feb 2023 10:53:32 -0800 [thread overview]
Message-ID: <Y+0qLPSsWZnG3XvJ@google.com> (raw)
In-Reply-To: <167642554451.2118945.4503850138465303711.stgit@magnolia>
On Tue, Feb 14, 2023 at 05:45:44PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Generate the section report between tests so that the summary report
> always reflects the outcome of the most recent test. Two usecases are
> envisioned here -- if a cluster-based test runner anticipates that the
> testrun could crash the VM, they can set REPORT_DIR to (say) an NFS
> mount to preserve the intermediate results. If the VM does indeed
> crash, the scheduler can examine the state of the crashed VM and move
> the tests to another VM. The second usecase is a reporting agent that
> runs in the VM to upload live results to a test dashboard.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> check | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>
> diff --git a/check b/check
> index 0bf5b22e06..14b398fd73 100755
> --- a/check
> +++ b/check
> @@ -844,6 +844,15 @@ function run_section()
> fi
> seqres="$REPORT_DIR/$seqnum"
>
> + # Generate the entire section report with whatever test results
> + # we have so far. Leave the $sect_time parameter empty so that
> + # it's a little more obvious that this test run is incomplete.
> + if $do_report; then
> + _make_section_report "$section" "${#try[*]}" \
> + "${#bad[*]}" "${#notrun[*]}" \
> + "" &> /dev/null
> + fi
> +
> mkdir -p $RESULT_DIR
> rm -f ${RESULT_DIR}/require_scratch*
> rm -f ${RESULT_DIR}/require_test*
>
This works for me, thanks!
Reviewed-and-tested-by: Leah Rumancik <leah.rumancik@gmail.com>
next prev parent reply other threads:[~2023-02-15 18:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 1:45 [PATCHSET v2 00/14] fstests: improve junit xml reporting Darrick J. Wong
2023-02-15 1:45 ` [PATCH 01/14] check: generate section reports between tests Darrick J. Wong
2023-02-15 18:53 ` Leah Rumancik [this message]
2023-02-15 1:45 ` [PATCH 02/14] report: derive an xml schema for the xunit report Darrick J. Wong
2023-02-15 1:45 ` [PATCH 03/14] report: capture the time zone in the test report timestamp Darrick J. Wong
2023-02-15 1:46 ` [PATCH 04/14] report: clarify the meaning of the timestamp attribute Darrick J. Wong
2023-02-15 1:46 ` [PATCH 05/14] report: record fstests start and report generation timestamps Darrick J. Wong
2023-02-15 1:46 ` [PATCH 06/14] report: encode cdata sections correctly Darrick J. Wong
2023-02-15 1:46 ` [PATCH 07/14] report: encode the kernel log as a separate xml element Darrick J. Wong
2023-02-15 1:46 ` [PATCH 08/14] report: sort properties by name Darrick J. Wong
2023-02-15 1:46 ` [PATCH 09/14] report: pass property value to _xunit_add_property Darrick J. Wong
2023-02-15 1:46 ` [PATCH 10/14] report: encode xml entities in property values Darrick J. Wong
2023-02-15 1:46 ` [PATCH 11/14] report: collect basic information about a test run Darrick J. Wong
2023-02-15 1:46 ` [PATCH 12/14] report: record xfs-specific " Darrick J. Wong
2023-02-15 1:46 ` [PATCH 13/14] report: record ext*-specific " Darrick J. Wong
2023-02-15 1:46 ` [PATCH 14/14] report: allow test runners to inject arbitrary values Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+0qLPSsWZnG3XvJ@google.com \
--to=leah.rumancik@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-xfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox