Re: [PATCH 01/14] check: generate section reports between tests

Leah Rumancik
2023-02-15T18:53:38Z

On Tue, Feb 14, 2023 at 05:45:44PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Generate the section report between tests so that the summary report
> always reflects the outcome of the most recent test. Two usecases are
> envisioned here -- if a cluster-based test runner anticipates that the
> testrun could crash the VM, they can set REPORT_DIR to (say) an NFS
> mount to preserve the intermediate results. If the VM does indeed
> crash, the scheduler can examine the state of the crashed VM and move
> the tests to another VM. The second usecase is a reporting agent that
> runs in the VM to upload live results to a test dashboard.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> check | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>
> diff --git a/check b/check
> index 0bf5b22e06..14b398fd73 100755
> --- a/check
> +++ b/check
> @@ -844,6 +844,15 @@ function run_section()
> fi
> seqres="$REPORT_DIR/$seqnum"
>
> + # Generate the entire section report with whatever test results
> + # we have so far. Leave the $sect_time parameter empty so that
> + # it's a little more obvious that this test run is incomplete.
> + if $do_report; then
> + _make_section_report "$section" "${#try[*]}" \
> + "${#bad[*]}" "${#notrun[*]}" \
> + "" &> /dev/null
> + fi
> +
> mkdir -p $RESULT_DIR
> rm -f ${RESULT_DIR}/require_scratch*
> rm -f ${RESULT_DIR}/require_test*
>

This works for me, thanks!

Reviewed-and-tested-by: Leah Rumancik <leah.rumancik@gmail.com>