[PATCH 5/8] report: pass property value to _xunit_add_property

Darrick J. Wong
2022-12-20T00:01:36Z

From: Darrick J. Wong <djwong@kernel.org>

Change this helper to require the caller to pass the value as the second
parameter. This prepares us to start reporting a lot more information
about a test run, not all of which are encoded as bash variables.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
common/report | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/report b/common/report
index b415a2641d..642e0426a6 100644
--- a/common/report
+++ b/common/report
@@ -24,9 +24,9 @@ encode_xml()
_xunit_add_property()
{
local name="$1"
- local value="${!name}"
+ local value="$2"

- if [ ! -z "$value" ]; then
+ if [ -n "$value" ]; then
echo -e "\t\t<property name=\"$name\" value=\"$value\"/>"
fi
}
@@ -67,7 +67,7 @@ ENDL
# Properties
echo -e "\t<properties>" >> $REPORT_DIR/result.xml
for p in "${REPORT_ENV_LIST[@]}"; do
- _xunit_add_property "$p"
+ _xunit_add_property "$p" "${!p}"
done | sort >> $REPORT_DIR/result.xml
echo -e "\t</properties>" >> $REPORT_DIR/result.xml
if [ -f $report ]; then