Re: [PATCH 1/8] check: generate section reports between tests

Qu Wenruo
2022-12-20T01:15:48Z

On 2022/12/20 08:01, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Generate the section report between tests so that the summary report
> always reflects the outcome of the most recent test. Two usecases are
> envisioned here -- if a cluster-based test runner anticipates that the
> testrun could crash the VM, they can set REPORT_DIR to (say) an NFS
> mount to preserve the intermediate results. If the VM does indeed
> crash, the scheduler can examine the state of the crashed VM and move
> the tests to another VM. The second usecase is a reporting agent that
> runs in the VM to upload live results to a test dashboard.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> check | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>
> diff --git a/check b/check
> index 1ff0f44af1..70a0b537b1 100755
> --- a/check
> +++ b/check
> @@ -842,6 +842,16 @@ function run_section()
> fi
> seqres="$REPORT_DIR/$seqnum"
>
> + # Generate the entire section report with whatever test results
> + # we have so far. Leave the $sect_time parameter empty so that
> + # it's a little more obvious that this test run is incomplete.
> + if $do_report; then
> + local sect_now=`_wallclock`
> + _make_section_report "$section" "${#try[*]}" \
> + "${#bad[*]}" "${#notrun[*]}" \
> + "" &> /dev/null
> + fi
> +

In fact that's exactly what I just wanted to do next...

However one problem I can't work around is the timestamp.

Currently our timestamp is the finish time, with this change our
timestamp is the start time.

I'm not sure if there is any strong definition on the timestamp, but
personally speaking, timestamp for the start time makes more sense to me.
But there may be some users relying on the timestamp to be the ending time?

Thanks,
Qu

> mkdir -p $RESULT_DIR
> rm -f ${RESULT_DIR}/require_scratch*
> rm -f ${RESULT_DIR}/require_test*
>