Re: [PATCH 2/2] xfs: online checking of the free rt extent count

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Oct 14, 2022 at 02:56:34PM +1100, Dave Chinner wrote:
> On Sun, Oct 02, 2022 at 11:20:05AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Teach the summary count checker to count the number of free realtime
> > extents and compare that to the superblock copy.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> >  fs/xfs/scrub/fscounters.c |   86 ++++++++++++++++++++++++++++++++++++++++++++-
> >  fs/xfs/scrub/scrub.h      |    8 ----
> >  2 files changed, 84 insertions(+), 10 deletions(-)
> 
> .....
> > @@ -288,6 +301,59 @@ xchk_fscount_aggregate_agcounts(
> >  	return 0;
> >  }
> >  
> > +#ifdef CONFIG_XFS_RT
> > +static inline int
> > +xchk_fscount_add_frextent(
> > +	struct xfs_mount		*mp,
> > +	struct xfs_trans		*tp,
> > +	const struct xfs_rtalloc_rec	*rec,
> > +	void				*priv)
> 
> This is a callback function, so it shouldn't be declared as
> "inline"....

Ok done.

--D

> With that fixed,
> 
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> 
> -- 
> Dave Chinner
> david@fromorbit.com