Re: [PATCH v1] xfstests: test xfs_spaceman fsuuid command

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Nov 17, 2022 at 12:43:04PM -0800, Darrick J. Wong wrote:
> On Wed, Nov 09, 2022 at 02:26:30PM -0800, Catherine Hoang wrote:
> > Add a test to verify the xfs_spaceman fsuuid functionality.
> > 
> > Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
> > ---
> >  tests/xfs/557     | 31 +++++++++++++++++++++++++++++++
> >  tests/xfs/557.out |  2 ++
> >  2 files changed, 33 insertions(+)
> >  create mode 100755 tests/xfs/557
> >  create mode 100644 tests/xfs/557.out
> > 
> > diff --git a/tests/xfs/557 b/tests/xfs/557
> > new file mode 100755
> > index 00000000..0b41e693
> > --- /dev/null
> > +++ b/tests/xfs/557
> > @@ -0,0 +1,31 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2022 Oracle.  All Rights Reserved.
> > +#
> > +# FS QA Test 557
> > +#
> > +# Test to verify xfs_spaceman fsuuid functionality
> > +#
> > +. ./common/preamble
> > +_begin_fstest auto quick spaceman
> > +
> > +# real QA test starts here
> > +_supported_fs xfs
> > +_require_xfs_spaceman_command "fsuuid"

Also -- I think you need to patch _require_xfs_io_command to try the
fsuuid command on the test fs and _notrun if the kernel doesn't
understand the GETFSUUID ioctl.

(Assuming the command is moving from xfs_spaceman to xfs_io.)

--D

> > +_require_scratch
> > +
> > +_scratch_mkfs >> $seqres.full
> > +_scratch_mount >> $seqres.full
> > +
> > +expected_uuid="$(_scratch_xfs_admin -u)"
> 
> A future xfs_admin.sh will be ported to call xfs_io if the filesystem is
> mounted, so you really ought to read the ondisk uuid straight from the
> debugger before mounting, and query the kernel after mounting:
> 
> _scratch_mkfs >> $seqres.full
> expected_uuid=$(_scratch_xfs_get_sb_field uuid)
> 
> _scratch_mount >> $seqres.full
> actual_uuid=$($XFS_IO_PROG -c fsuuid $SCRATCH_MNT)
> if [ "$expected_uuid" != "$actual_uuid" ]; then
> 	...
> fi
> 
> --D
> 
> > +actual_uuid="$($XFS_SPACEMAN_PROG -c "fsuuid" $SCRATCH_MNT)"
> > +
> > +if [ "$expected_uuid" != "$actual_uuid" ]; then
> > +        echo "expected UUID ($expected_uuid) != actual UUID ($actual_uuid)"
> > +fi
> > +
> > +echo "Silence is golden"
> > +
> > +# success, all done
> > +status=0
> > +exit
> > diff --git a/tests/xfs/557.out b/tests/xfs/557.out
> > new file mode 100644
> > index 00000000..1f1ae1d4
> > --- /dev/null
> > +++ b/tests/xfs/557.out
> > @@ -0,0 +1,2 @@
> > +QA output created by 557
> > +Silence is golden
> > -- 
> > 2.25.1
> >