[ANNOUNCE] xfsprogs for-next branch updated

[ANNOUNCE] xfsprogs for-next branch updated

[Carlos Maiolino]

Hello.

The xfsprogs, for-next branch located at:

https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/log/?h=for-next

has just been updated.

The new head is:

b827e2318 xfs: fix sb write verify for lazysbcount


This update contains only the libxfs-sync for Linux 6.1, and will serve as a
base for the xfsprogs 6.1 release.
Please, let me know if any issue.


The following commits are now in the for-next tree:

[b827e2318] xfs: fix sb write verify for lazysbcount
[7257eb3ed] xfs: rename XFS_REFC_COW_START to _COWFLAG
[7accbcd00] xfs: fix uninitialized list head in struct xfs_refcount_recovery
[8b2b27581] xfs: fix agblocks check in the cow leftover recovery function
[817ea9f0f] xfs: check record domain when accessing refcount records
[f275d70e8] xfs: remove XFS_FIND_RCEXT_SHARED and _COW
[cc2a3c2ad] xfs: refactor domain and refcount checking
[8160aeff0] xfs: report refcount domain in tracepoints
[6b2f464dd] xfs: track cow/shared record domains explicitly in xfs_refcount_irec
[bec88ec72] xfs: move _irec structs to xfs_types.h
[7ccbdec2b] xfs: check deferred refcount op continuation parameters
[b3f9ae08e] xfs: create a predicate to verify per-AG extents
[2d5166b9d] xfs: make sure aglen never goes negative in xfs_refcount_adjust_extents
[4b69afdc4] xfs: refactor all the EFI/EFD log item sizeof logic
[d267ac6a0] xfs: fix memcpy fortify errors in EFI log format copying
[227bc97f1] xfs: increase rename inode reservation
[20798cc06] xfs: fix exception caused by unexpected illegal bestcount in leaf dir
[11d2f5afc] treewide: use get_random_u32() when possible
[4947ac5b3] treewide: use prandom_u32_max() when possible, part 1
[1a3bfffee] xfs: rearrange the logic and remove the broken comment for xfs_dir2_isxx
[04d4c27af] xfs: trim the mapp array accordingly in xfs_da_grow_inode_int
[e8dbbca18] xfs: Remove the unneeded result variable
[be98db856] xfs: clean up "%Ld/%Lu" which doesn't meet C standard


-- 
Carlos Maiolino

Re: [ANNOUNCE] xfsprogs for-next branch updated

[Darrick J. Wong]

On Mon, Nov 21, 2022 at 03:35:47PM +0100, Carlos Maiolino wrote:
> Hello.
> 
> The xfsprogs, for-next branch located at:
> 
> https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/log/?h=for-next
> 
> has just been updated.
> 
> The new head is:
> 
> b827e2318 xfs: fix sb write verify for lazysbcount
> 
> 
> This update contains only the libxfs-sync for Linux 6.1, and will serve as a
> base for the xfsprogs 6.1 release.
> Please, let me know if any issue.
> 
> 
> The following commits are now in the for-next tree:
> 
> [b827e2318] xfs: fix sb write verify for lazysbcount

Why was this commit merged for xfsprogs 6.1?  That patch is queued for
kernel 6.2 in for-next, but the merge window is not open yet.

--D

> [7257eb3ed] xfs: rename XFS_REFC_COW_START to _COWFLAG
> [7accbcd00] xfs: fix uninitialized list head in struct xfs_refcount_recovery
> [8b2b27581] xfs: fix agblocks check in the cow leftover recovery function
> [817ea9f0f] xfs: check record domain when accessing refcount records
> [f275d70e8] xfs: remove XFS_FIND_RCEXT_SHARED and _COW
> [cc2a3c2ad] xfs: refactor domain and refcount checking
> [8160aeff0] xfs: report refcount domain in tracepoints
> [6b2f464dd] xfs: track cow/shared record domains explicitly in xfs_refcount_irec
> [bec88ec72] xfs: move _irec structs to xfs_types.h
> [7ccbdec2b] xfs: check deferred refcount op continuation parameters
> [b3f9ae08e] xfs: create a predicate to verify per-AG extents
> [2d5166b9d] xfs: make sure aglen never goes negative in xfs_refcount_adjust_extents
> [4b69afdc4] xfs: refactor all the EFI/EFD log item sizeof logic
> [d267ac6a0] xfs: fix memcpy fortify errors in EFI log format copying
> [227bc97f1] xfs: increase rename inode reservation
> [20798cc06] xfs: fix exception caused by unexpected illegal bestcount in leaf dir
> [11d2f5afc] treewide: use get_random_u32() when possible
> [4947ac5b3] treewide: use prandom_u32_max() when possible, part 1
> [1a3bfffee] xfs: rearrange the logic and remove the broken comment for xfs_dir2_isxx
> [04d4c27af] xfs: trim the mapp array accordingly in xfs_da_grow_inode_int
> [e8dbbca18] xfs: Remove the unneeded result variable
> [be98db856] xfs: clean up "%Ld/%Lu" which doesn't meet C standard
> 
> 
> -- 
> Carlos Maiolino

Re: [ANNOUNCE] xfsprogs for-next branch updated

[Carlos Maiolino]

On Mon, Nov 21, 2022 at 04:25:25PM -0800, Darrick J. Wong wrote:
> On Mon, Nov 21, 2022 at 03:35:47PM +0100, Carlos Maiolino wrote:
> > Hello.
> >
> > The xfsprogs, for-next branch located at:
> >
> > https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/log/?h=for-next
> >
> > has just been updated.
> >
> > The new head is:
> >
> > b827e2318 xfs: fix sb write verify for lazysbcount
> >
> >
> > This update contains only the libxfs-sync for Linux 6.1, and will serve as a
> > base for the xfsprogs 6.1 release.
> > Please, let me know if any issue.
> >
> >
> > The following commits are now in the for-next tree:
> >
> > [b827e2318] xfs: fix sb write verify for lazysbcount
> 
> Why was this commit merged for xfsprogs 6.1?  That patch is queued for
> kernel 6.2 in for-next, but the merge window is not open yet.
> 

Since 6.1 isn't out yet, I did a `libxfs-apply <last libxfscommit>..`, my fault
for not spotting you've patches already queued for 6.2. I'm planning to release
xfsprogs-6.1 some time later after linux 6.1 is out, so this patch will already
be in Linus's tree by the time. I can also get this patch out of the tree when I
push the other patches I have queued up, although I'm trying to avoid doing
forced updates to the tree. Is it ok for you to leave it in the tree, or better
remove it by now?
Cheers

-- 
Carlos Maiolino

Re: [ANNOUNCE] xfsprogs for-next branch updated

[Darrick J. Wong]

On Tue, Nov 22, 2022 at 10:53:00AM +0100, Carlos Maiolino wrote:
> On Mon, Nov 21, 2022 at 04:25:25PM -0800, Darrick J. Wong wrote:
> > On Mon, Nov 21, 2022 at 03:35:47PM +0100, Carlos Maiolino wrote:
> > > Hello.
> > >
> > > The xfsprogs, for-next branch located at:
> > >
> > > https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/log/?h=for-next
> > >
> > > has just been updated.
> > >
> > > The new head is:
> > >
> > > b827e2318 xfs: fix sb write verify for lazysbcount
> > >
> > >
> > > This update contains only the libxfs-sync for Linux 6.1, and will serve as a
> > > base for the xfsprogs 6.1 release.
> > > Please, let me know if any issue.
> > >
> > >
> > > The following commits are now in the for-next tree:
> > >
> > > [b827e2318] xfs: fix sb write verify for lazysbcount
> > 
> > Why was this commit merged for xfsprogs 6.1?  That patch is queued for
> > kernel 6.2 in for-next, but the merge window is not open yet.
> > 
> 
> Since 6.1 isn't out yet, I did a `libxfs-apply <last libxfscommit>..`, my fault
> for not spotting you've patches already queued for 6.2. I'm planning to release
> xfsprogs-6.1 some time later after linux 6.1 is out, so this patch will already
> be in Linus's tree by the time. I can also get this patch out of the tree when I
> push the other patches I have queued up, although I'm trying to avoid doing
> forced updates to the tree. Is it ok for you to leave it in the tree, or better
> remove it by now?

For this one patch it doesn't matter since the race only happens when
there are multiple threads updating the inode summary counts.  Userspace
doesn't do any concurrent inobt updates, so the fix arriving early ought
to be benign.

(That said, the only thing you have to do if you push -f is let everyone
know that for-next has been **REBASED**, but I agree with the sentiment
of only doing it when it's really important.)

--D

> Cheers
> 
> -- 
> Carlos Maiolino

[ANNOUNCE] xfsprogs for-next branch updated

[Carlos Maiolino]

Hello.

The xfsprogs for-next branch, located at:

https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/refs/?h=for-next

Has just been updated.

This should contain all patches on linux-xfs list with RwB tags, not yet
included in the tree.
If you have patches reviewed on the list, not included here, please let me know.


New head:

2dac91b3d xfs_repair: Fix rmaps_verify_btree() error path

New commits:

Carlos Maiolino (2):
      [fbd9b2363] xfs_repair: Fix check_refcount() error path
      [2dac91b3d] xfs_repair: Fix rmaps_verify_btree() error path

Darrick J. Wong (9):
      [60066f61c] libxfs: consume the xfs_warn mountpoint argument
      [b6fef47a8] misc: add static to various sourcefile-local functions
      [a946664de] misc: add missing includes
      [b84d0823d] xfs_db: fix octal conversion logic
      [e9dea7eff] xfs_db: fix printing of reverse mapping record blockcounts
      [978c3087b] xfs_repair: don't crash on unknown inode parents in dry run mode
      [945c7341d] xfs_repair: retain superblock buffer to avoid write hook deadlock
      [2b9d6f15b] xfs_{db,repair}: fix XFS_REFC_COW_START usage
      [765809a0d] mkfs.xfs: add mkfs config file for the 6.1 LTS kernel

Diffstat:

 db/btblock.c             |  2 +-
 db/check.c               |  4 ++--
 db/namei.c               |  2 +-
 db/write.c               |  4 ++--
 io/pread.c               |  2 +-
 libfrog/linux.c          |  1 +
 libxfs/libxfs_api_defs.h |  2 ++
 libxfs/libxfs_io.h       |  1 +
 libxfs/libxfs_priv.h     |  2 +-
 libxfs/rdwr.c            |  8 ++++++++
 libxfs/util.c            |  1 +
 mkfs/Makefile            |  3 ++-
 mkfs/lts_6.1.conf        | 14 ++++++++++++++
 mkfs/xfs_mkfs.c          |  2 +-
 repair/phase2.c          |  8 ++++++++
 repair/phase6.c          |  9 ++++++++-
 repair/protos.h          |  1 +
 repair/rmap.c            | 43 ++++++++++++++++++++-----------------------
 repair/scan.c            | 22 ++++++++++++++++------
 repair/xfs_repair.c      | 77
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------
 scrub/inodes.c           |  2 +-
 21 files changed, 159 insertions(+), 51 deletions(-)
 create mode 100644 mkfs/lts_6.1.conf


-- 
Carlos Maiolino

[ANNOUNCE] xfsprogs for-next branch updated

[Carlos Maiolino]

Hello folks.

The xfsprogs for-next branch, located at:

https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/?h=for-next

has just been updated.

Unless any urgent bug fix appears during the next week, this is the last batch
of patches staged for release 6.1, scheduled to be released next Friday.



New head:

79ba1e15d fsck.xfs: mount/umount xfs fs to replay log before running xfs_repair

New commits:

Darrick J. Wong (2):
      [f6fb1c078] xfs_io: don't display stripe alignment flags for realtime files
      [e229a59f0] xfs_db: create separate struct and field definitions for finobts

Srikanth C S (1):
      [79ba1e15d] fsck.xfs: mount/umount xfs fs to replay log before running xfs_repair



Cheers, and happy holidays.

-- 
Carlos Maiolino

[ANNOUNCE] xfsprogs for-next branch updated

[Carlos Maiolino]

Hello folks.

This is an 'extra' xfsprogs for-next branch update before the v6.1 release on
tomorrow, so that we can include a xfs_db fix in the new version.

This update only contains this commit:

Darrick J. Wong (1):
      7374f58bf xfs_db: fix dir3 block magic check


-- 
Carlos Maiolino