Re: [PATCH 0/2] fsdax,xfs: fix warning messages

Darrick J. Wong
2022-11-30T04:16:32Z

On Tue, Nov 29, 2022 at 07:59:14PM -0800, Dan Williams wrote:
> [ add Andrew ]
>
> Shiyang Ruan wrote:
> > Many testcases failed in dax+reflink mode with warning message in dmesg.
> > This also effects dax+noreflink mode if we run the test after a
> > dax+reflink test. So, the most urgent thing is solving the warning
> > messages.
> >
> > Patch 1 fixes some mistakes and adds handling of CoW cases not
> > previously considered (srcmap is HOLE or UNWRITTEN).
> > Patch 2 adds the implementation of unshare for fsdax.
> >
> > With these fixes, most warning messages in dax_associate_entry() are
> > gone. But honestly, generic/388 will randomly failed with the warning.
> > The case shutdown the xfs when fsstress is running, and do it for many
> > times. I think the reason is that dax pages in use are not able to be
> > invalidated in time when fs is shutdown. The next time dax page to be
> > associated, it still remains the mapping value set last time. I'll keep
> > on solving it.
> >
> > The warning message in dax_writeback_one() can also be fixed because of
> > the dax unshare.
>
> Thank you for digging in on this, I had been pinned down on CXL tasks
> and worried that we would need to mark FS_DAX broken for a cycle, so
> this is timely.
>
> My only concern is that these patches look to have significant collisions with
> the fsdax page reference counting reworks pending in linux-next. Although,
> those are still sitting in mm-unstable:
>
> http://lore.kernel.org/r/20221108162059.2ee440d5244657c4f16bdca0@linux-foundation.org
>
> My preference would be to move ahead with both in which case I can help
> rebase these fixes on top. In that scenario everything would go through
> Andrew.
>
> However, if we are getting too late in the cycle for that path I think
> these dax-fixes take precedence, and one more cycle to let the page
> reference count reworks sit is ok.

Well now that raises some interesting questions -- dax and reflink are
totally broken on 6.1. I was thinking about cramming them into 6.2 as a
data corruption fix on the grounds that is not an acceptable state of
affairs.

OTOH we're past -rc7, which is **really late** to be changing core code.
Then again, there aren't so many fsdax users and nobody's complained
about 6.0/6.1 being busted, so perhaps the risk of regression isn't so
bad? Then again, that could be a sign that this could wait, if you and
Andrew are really eager to merge the reworks.

Just looking at the stuff that's still broken with dax+reflink -- I
noticed that xfs/550-552 (aka the dax poison tests) are still regressing
on reflink filesystems.

So, uh, what would this patchset need to change if the "fsdax page
reference counting reworks" were applied? Would it be changing the page
refcount instead of stashing that in page->index?

--D

> > Shiyang Ruan (2):
> > fsdax,xfs: fix warning messages at dax_[dis]associate_entry()
> > fsdax,xfs: port unshare to fsdax
> >
> > fs/dax.c | 166 ++++++++++++++++++++++++++++++-------------
> > fs/xfs/xfs_iomap.c | 6 +-
> > fs/xfs/xfs_reflink.c | 8 ++-
> > include/linux/dax.h | 2 +
> > 4 files changed, 129 insertions(+), 53 deletions(-)
> >
> > --
> > 2.38.1