public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] fsverity: remove debug messages and CONFIG_FS_VERITY_DEBUG
Date: Tue, 3 Jan 2023 22:58:44 -0800	[thread overview]
Message-ID: <Y7UjpFWy6R+J4BLV@sol.localdomain> (raw)
In-Reply-To: <20221215060420.60692-1-ebiggers@kernel.org>

On Wed, Dec 14, 2022 at 10:04:20PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> I've gotten very little use out of these debug messages, and I'm not
> aware of anyone else having used them.
> 
> Indeed, sprinkling pr_debug around is not really a best practice these
> days, especially for filesystem code.  Tracepoints are used instead.
> 
> Let's just remove these and start from a clean slate.
> 
> This change does not affect info, warning, and error messages.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  fs/verity/Kconfig            |  8 --------
>  fs/verity/enable.c           | 11 -----------
>  fs/verity/fsverity_private.h |  4 ----
>  fs/verity/init.c             |  1 -
>  fs/verity/open.c             | 21 ++-------------------
>  fs/verity/signature.c        |  2 --
>  fs/verity/verify.c           | 13 -------------
>  7 files changed, 2 insertions(+), 58 deletions(-)

Applied for 6.3.  (To
https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git/log/?h=fsverity for now,
but there might be a new git repo soon, as is being discussed elsewhere.)

- Eric

      reply	other threads:[~2023-01-04  6:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15  6:04 [PATCH] fsverity: remove debug messages and CONFIG_FS_VERITY_DEBUG Eric Biggers
2023-01-04  6:58 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7UjpFWy6R+J4BLV@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox