From: "Darrick J. Wong" <djwong@kernel.org>
To: Wengang Wang <wen.gang.wang@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix extent busy updating
Date: Wed, 4 Jan 2023 08:24:42 -0800 [thread overview]
Message-ID: <Y7WoStJT4ImufLct@magnolia> (raw)
In-Reply-To: <20230103193217.4941-1-wen.gang.wang@oracle.com>
On Tue, Jan 03, 2023 at 11:32:17AM -0800, Wengang Wang wrote:
> In xfs_extent_busy_update_extent() case 6 and 7, whenever bno is modified on
> extent busy, the relavent length has to be modified accordingly.
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
> fs/xfs/xfs_extent_busy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_extent_busy.c b/fs/xfs/xfs_extent_busy.c
> index ad22a003f959..f3d328e4a440 100644
> --- a/fs/xfs/xfs_extent_busy.c
> +++ b/fs/xfs/xfs_extent_busy.c
> @@ -236,6 +236,7 @@ xfs_extent_busy_update_extent(
> *
> */
> busyp->bno = fend;
> + busyp->length = bend - fend;
Looks correct to me, but how did you find this? Is there some sort of
test case we could attach to this?
--D
> } else if (bbno < fbno) {
> /*
> * Case 8:
> --
> 2.21.0 (Apple Git-122.2)
>
next prev parent reply other threads:[~2023-01-04 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 19:32 [PATCH] xfs: fix extent busy updating Wengang Wang
2023-01-04 16:24 ` Darrick J. Wong [this message]
2023-01-04 17:41 ` Wengang Wang
2023-01-05 19:58 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7WoStJT4ImufLct@magnolia \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wen.gang.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox