Re: [PATCH v2 00/11] fsverity: support for non-4K pages

Ojaswin Mujoo
2023-01-05T11:25:18Z

On Tue, Jan 03, 2023 at 11:25:18PM -0800, Eric Biggers wrote:
>

Hi Eric,

> Thanks Ojaswin! That's a good point about generic/692. The right fix for it is
> to make it use $FSV_BLOCK_SIZE instead of 4K in its calculations.
Yes, that should fix the issue, I'll try to send in a patch for this
when I find some time.

>
> I suppose you saw that issue by running the test on ext4 with fs_block_size ==
> page_size == 64K, causing xfstests to use merkle_tree_block_size == 64K by
> default. Thanks for doing that; that's something I haven't been able to test
> yet. My focus has been on merkle_tree_block_size < page_size.
Correct, I was testing "everything = 64k" scenario when I
noticed the slowdown.

> merkle_tree_block_size > 4K should just work, though, assuming
> merkle_tree_block_size <= min(fs_block_size, page_size). (Or
> merkle_tree_block_size == fs_block_size == page_size before this patch series.)

Yes true, I still tested them just in case :)

Regards,
Ojaswin