From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: don't use BMBT btree split workers for IO completion
Date: Thu, 19 Jan 2023 10:33:26 -0800 [thread overview]
Message-ID: <Y8mM9rdRUU98+HEW@infradead.org> (raw)
In-Reply-To: <20230119010334.1982938-1-david@fromorbit.com>
On Thu, Jan 19, 2023 at 12:03:34PM +1100, Dave Chinner wrote:
> The other place we can be called for a BMBT split without a
> preceeding allocation is __xfs_bunmapi() when punching out the
> center of an existing extent. We don't remove extents in the IO
> path, so these operations don't tend to be called with a lot of
> stack consumed. Hence we don't really need to ship the split off to
> a worker thread in these cases, either.
So I agree with the fix. But the t_firstblock seems a bit opaque.
We do have a lot of comments, which is good but it still feels
a little fragile to me. Is there a good reason we can't do an
explicit flag to document the intent better?
next prev parent reply other threads:[~2023-01-19 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 1:03 [PATCH] xfs: don't use BMBT btree split workers for IO completion Dave Chinner
2023-01-19 18:33 ` Christoph Hellwig [this message]
2023-01-19 20:20 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2022-12-20 21:07 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8mM9rdRUU98+HEW@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox