From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: xfs_buf_item_size_segment() needs to pass segment offset
Date: Tue, 2 Mar 2021 09:37:24 -0500 [thread overview]
Message-ID: <YD5NpMOcaVymLPwC@bfoster> (raw)
In-Reply-To: <20210223044636.3280862-3-david@fromorbit.com>
On Tue, Feb 23, 2021 at 03:46:35PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Otherwise it doesn't correctly calculate the number of vectors
> in a logged buffer that has a contiguous map that gets split into
> multiple regions because the range spans discontigous memory.
>
> Probably never been hit in practice - we don't log contiguous ranges
> on unmapped buffers (inode clusters).
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_buf_item.c | 38 +++++++++++++++++++-------------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c
> index 0628a65d9c55..91dc7d8c9739 100644
> --- a/fs/xfs/xfs_buf_item.c
> +++ b/fs/xfs/xfs_buf_item.c
> @@ -55,6 +55,18 @@ xfs_buf_log_format_size(
> (blfp->blf_map_size * sizeof(blfp->blf_data_map[0]));
> }
>
> +static inline bool
> +xfs_buf_item_straddle(
> + struct xfs_buf *bp,
> + uint offset,
> + int next_bit,
> + int last_bit)
> +{
> + return xfs_buf_offset(bp, offset + (next_bit << XFS_BLF_SHIFT)) !=
> + (xfs_buf_offset(bp, offset + (last_bit << XFS_BLF_SHIFT)) +
> + XFS_BLF_CHUNK);
> +}
> +
> /*
> * Return the number of log iovecs and space needed to log the given buf log
> * item segment.
> @@ -67,6 +79,7 @@ STATIC void
> xfs_buf_item_size_segment(
> struct xfs_buf_log_item *bip,
> struct xfs_buf_log_format *blfp,
> + uint offset,
> int *nvecs,
> int *nbytes)
> {
> @@ -101,12 +114,8 @@ xfs_buf_item_size_segment(
> */
> if (next_bit == -1) {
> break;
> - } else if (next_bit != last_bit + 1) {
> - last_bit = next_bit;
> - (*nvecs)++;
> - } else if (xfs_buf_offset(bp, next_bit * XFS_BLF_CHUNK) !=
> - (xfs_buf_offset(bp, last_bit * XFS_BLF_CHUNK) +
> - XFS_BLF_CHUNK)) {
> + } else if (next_bit != last_bit + 1 ||
> + xfs_buf_item_straddle(bp, offset, next_bit, last_bit)) {
> last_bit = next_bit;
> (*nvecs)++;
> } else {
> @@ -141,8 +150,10 @@ xfs_buf_item_size(
> int *nbytes)
> {
> struct xfs_buf_log_item *bip = BUF_ITEM(lip);
> + struct xfs_buf *bp = bip->bli_buf;
> int i;
> int bytes;
> + uint offset = 0;
>
> ASSERT(atomic_read(&bip->bli_refcount) > 0);
> if (bip->bli_flags & XFS_BLI_STALE) {
> @@ -184,8 +195,9 @@ xfs_buf_item_size(
> */
> bytes = 0;
> for (i = 0; i < bip->bli_format_count; i++) {
> - xfs_buf_item_size_segment(bip, &bip->bli_formats[i],
> + xfs_buf_item_size_segment(bip, &bip->bli_formats[i], offset,
> nvecs, &bytes);
> + offset += BBTOB(bp->b_maps[i].bm_len);
> }
>
> /*
> @@ -212,18 +224,6 @@ xfs_buf_item_copy_iovec(
> nbits * XFS_BLF_CHUNK);
> }
>
> -static inline bool
> -xfs_buf_item_straddle(
> - struct xfs_buf *bp,
> - uint offset,
> - int next_bit,
> - int last_bit)
> -{
> - return xfs_buf_offset(bp, offset + (next_bit << XFS_BLF_SHIFT)) !=
> - (xfs_buf_offset(bp, offset + (last_bit << XFS_BLF_SHIFT)) +
> - XFS_BLF_CHUNK);
> -}
> -
> static void
> xfs_buf_item_format_segment(
> struct xfs_buf_log_item *bip,
> --
> 2.28.0
>
next prev parent reply other threads:[~2021-03-03 3:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 4:46 [PATCH 0/3] xfs: buffer log item optimisations Dave Chinner
2021-02-23 4:46 ` [PATCH 1/3] xfs: reduce buffer log item shadow allocations Dave Chinner
2021-02-24 21:29 ` Darrick J. Wong
2021-02-24 22:13 ` Dave Chinner
2021-03-02 14:37 ` Brian Foster
2021-02-23 4:46 ` [PATCH 2/3] xfs: xfs_buf_item_size_segment() needs to pass segment offset Dave Chinner
2021-02-24 21:34 ` Darrick J. Wong
2021-03-02 14:37 ` Brian Foster [this message]
2021-02-23 4:46 ` [PATCH 3/3] xfs: optimise xfs_buf_item_size/format for contiguous regions Dave Chinner
2021-02-24 21:39 ` Darrick J. Wong
2021-03-02 14:38 ` Brian Foster
2021-02-25 9:01 ` [PATCH 0/3] xfs: buffer log item optimisations Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD5NpMOcaVymLPwC@bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).