* [PATCH] man: document XFS_XFLAG_APPEND behavior for directories
@ 2021-02-24 22:29 Darrick J. Wong
2021-02-24 22:31 ` Eric Sandeen
2021-02-25 18:57 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2021-02-24 22:29 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <djwong@kernel.org>
For directories, the APPEND flag means that files cannot be unlinked
from the directory. Files can be linked in or created, just not
unlinked. Document this behavior, since it's been in the VFS for years
though not explicitly mentioned. This patch is in preparation for
trying to hoist the fsgetxattr ioctl documentation to the man-pages
project.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
man/man2/ioctl_xfs_fsgetxattr.2 | 1 +
1 file changed, 1 insertion(+)
diff --git a/man/man2/ioctl_xfs_fsgetxattr.2 b/man/man2/ioctl_xfs_fsgetxattr.2
index e2cbfca3..2c626a7e 100644
--- a/man/man2/ioctl_xfs_fsgetxattr.2
+++ b/man/man2/ioctl_xfs_fsgetxattr.2
@@ -104,6 +104,7 @@ will be returned.
.B XFS_XFLAG_APPEND
The file is append-only - it can only be opened in append mode for
writing.
+For directories, this means that files cannot be unlinked from this directory.
Only the superuser or a process possessing the CAP_LINUX_IMMUTABLE
capability can set or clear this flag.
.TP
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] man: document XFS_XFLAG_APPEND behavior for directories
2021-02-24 22:29 [PATCH] man: document XFS_XFLAG_APPEND behavior for directories Darrick J. Wong
@ 2021-02-24 22:31 ` Eric Sandeen
2021-02-25 18:57 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2021-02-24 22:31 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs
On 2/24/21 4:29 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> For directories, the APPEND flag means that files cannot be unlinked
> from the directory. Files can be linked in or created, just not
> unlinked. Document this behavior, since it's been in the VFS for years
> though not explicitly mentioned. This patch is in preparation for
> trying to hoist the fsgetxattr ioctl documentation to the man-pages
> project.
sounds good.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> man/man2/ioctl_xfs_fsgetxattr.2 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/man/man2/ioctl_xfs_fsgetxattr.2 b/man/man2/ioctl_xfs_fsgetxattr.2
> index e2cbfca3..2c626a7e 100644
> --- a/man/man2/ioctl_xfs_fsgetxattr.2
> +++ b/man/man2/ioctl_xfs_fsgetxattr.2
> @@ -104,6 +104,7 @@ will be returned.
> .B XFS_XFLAG_APPEND
> The file is append-only - it can only be opened in append mode for
> writing.
> +For directories, this means that files cannot be unlinked from this directory.
> Only the superuser or a process possessing the CAP_LINUX_IMMUTABLE
> capability can set or clear this flag.
> .TP
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] man: document XFS_XFLAG_APPEND behavior for directories
2021-02-24 22:29 [PATCH] man: document XFS_XFLAG_APPEND behavior for directories Darrick J. Wong
2021-02-24 22:31 ` Eric Sandeen
@ 2021-02-25 18:57 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-02-25 18:57 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, xfs
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-25 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-24 22:29 [PATCH] man: document XFS_XFLAG_APPEND behavior for directories Darrick J. Wong
2021-02-24 22:31 ` Eric Sandeen
2021-02-25 18:57 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).