From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DBEC433C1 for ; Sun, 28 Mar 2021 16:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71BD661958 for ; Sun, 28 Mar 2021 16:47:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231187AbhC1Qqm (ORCPT ); Sun, 28 Mar 2021 12:46:42 -0400 Received: from out20-1.mail.aliyun.com ([115.124.20.1]:51361 "EHLO out20-1.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbhC1Qqg (ORCPT ); Sun, 28 Mar 2021 12:46:36 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07437051|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.100728-0.000827389-0.898445;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047207;MF=guan@eryu.me;NM=1;PH=DS;RN=5;RT=5;SR=0;TI=SMTPD_---.Jrb4lbm_1616949989; Received: from localhost(mailfrom:guan@eryu.me fp:SMTPD_---.Jrb4lbm_1616949989) by smtp.aliyun-inc.com(10.147.42.22); Mon, 29 Mar 2021 00:46:29 +0800 Date: Mon, 29 Mar 2021 00:46:29 +0800 From: Eryu Guan To: Gao Xiang Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, "Darrick J. Wong" , Zorro Lang Subject: Re: [RFC PATCH v3 3/3] xfs: stress test for shrinking free space in the last AG Message-ID: References: <20210315111926.837170-1-hsiangkao@redhat.com> <20210315111926.837170-4-hsiangkao@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315111926.837170-4-hsiangkao@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Mar 15, 2021 at 07:19:26PM +0800, Gao Xiang wrote: > This adds a stress testcase to shrink free space as much as > possible in the last AG with background fsstress workload. > > The expectation is that no crash happens with expected output. > > Signed-off-by: Gao Xiang > --- > tests/xfs/991 | 122 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/xfs/991.out | 8 +++ > tests/xfs/group | 1 + > 3 files changed, 131 insertions(+) > create mode 100755 tests/xfs/991 > create mode 100644 tests/xfs/991.out > > diff --git a/tests/xfs/991 b/tests/xfs/991 > new file mode 100755 > index 00000000..7e7d318e > --- /dev/null > +++ b/tests/xfs/991 > @@ -0,0 +1,122 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2020-2021 Red Hat, Inc. All Rights Reserved. > +# > +# FS QA Test 991 > +# > +# XFS online shrinkfs stress test > +# > +# This test attempts to shrink unused space as much as possible with > +# background fsstress workload. It will decrease the shrink size if > +# larger size fails. And totally repeat 2 * TIME_FACTOR times. > +# > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter > + > +create_scratch() > +{ > + _scratch_mkfs_xfs $@ | tee -a $seqres.full | \ > + _filter_mkfs 2>$tmp.mkfs >/dev/null > + . $tmp.mkfs > + > + if ! _try_scratch_mount 2>/dev/null; then > + echo "failed to mount $SCRATCH_DEV" > + exit 1 > + fi _scratch_mount will do the check and _fail the test on mount failure. > + > + # fix the reserve block pool to a known size so that the enospc > + # calculations work out correctly. > + _scratch_resvblks 1024 > /dev/null 2>&1 > +} > + > +fill_scratch() > +{ > + $XFS_IO_PROG -f -c "falloc -k 0 $1" $SCRATCH_MNT/resvfile > +} > + > +stress_scratch() > +{ > + procs=3 > + nops=$((1000 * LOAD_FACTOR)) Declare procs and nops as local. > + # -w ensures that the only ops are ones which cause write I/O > + FSSTRESS_ARGS=`_scale_fsstress_args -d $SCRATCH_MNT -w -p $procs \ > + -n $nops $FSSTRESS_AVOID` > + $FSSTRESS_PROG $FSSTRESS_ARGS >> $seqres.full 2>&1 & I think it's more explicit to run run stress_scratch in background, instead run fsstress in background implicit. > +} > + > +# real QA test starts here > +_supported_fs xfs _require_scratch > +_require_xfs_shrink > +_require_xfs_io_command "falloc" > + > +rm -f $seqres.full > +_scratch_mkfs_xfs | tee -a $seqres.full | _filter_mkfs 2>$tmp.mkfs > +. $tmp.mkfs # extract blocksize and data size for scratch device > + > +decsize=`expr 42 \* 1048576` # shrink in chunks of this size at most > +endsize=`expr 125 \* 1048576` # stop after shrinking this big > +[ `expr $endsize / $dbsize` -lt $dblocks ] || _notrun "Scratch device too small" > + > +nags=2 > +totalcount=$((2 * TIME_FACTOR)) > + > +while [ $totalcount -gt 0 ]; do > + size=`expr 1010 \* 1048576` # 1010 megabytes initially > + logblks=$(_scratch_find_xfs_min_logblocks -dsize=${size} -dagcount=${nags}) > + > + create_scratch -lsize=${logblks}b -dsize=${size} -dagcount=${nags} > + > + for i in `seq 125 -1 90`; do > + fillsize=`expr $i \* 1048576` > + out="$(fill_scratch $fillsize 2>&1)" > + echo "$out" | grep -q 'No space left on device' && continue > + test -n "${out}" && echo "$out" > + break > + done > + > + while [ $size -gt $endsize ]; do > + stress_scratch So just call stress_scratch & here? So it's clear that we put stress_scratch in background, and the 'wait' below is waiting for it. Thanks, Eryu > + sleep 1 > + > + decb=`expr $decsize / $dbsize` # in data blocks > + while [ $decb -gt 0 ]; do > + sizeb=`expr $size / $dbsize - $decb` > + > + $XFS_GROWFS_PROG -D ${sizeb} $SCRATCH_MNT \ > + >> $seqres.full 2>&1 && break > + > + [ $decb -gt 100 ] && decb=`expr $decb + $RANDOM % 10` > + decb=`expr $decb / 2` > + done > + > + wait > + [ $decb -eq 0 ] && break > + > + # get latest dblocks > + $XFS_INFO_PROG $SCRATCH_MNT 2>&1 | _filter_mkfs 2>$tmp.growfs >/dev/null > + . $tmp.growfs > + > + size=`expr $dblocks \* $dbsize` > + _scratch_unmount > + _repair_scratch_fs >> $seqres.full > + _scratch_mount > + done > + > + _scratch_unmount > + _repair_scratch_fs >> $seqres.full > + totalcount=`expr $totalcount - 1` > +done > + > +echo "*** done" > +status=0 > +exit > diff --git a/tests/xfs/991.out b/tests/xfs/991.out > new file mode 100644 > index 00000000..e8209672 > --- /dev/null > +++ b/tests/xfs/991.out > @@ -0,0 +1,8 @@ > +QA output created by 991 > +meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks > +data = bsize=XXX blocks=XXX, imaxpct=PCT > + = sunit=XXX swidth=XXX, unwritten=X > +naming =VERN bsize=XXX > +log =LDEV bsize=XXX blocks=XXX > +realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX > +*** done > diff --git a/tests/xfs/group b/tests/xfs/group > index a7981b67..cf190b59 100644 > --- a/tests/xfs/group > +++ b/tests/xfs/group > @@ -526,3 +526,4 @@ > 526 auto quick mkfs > 527 auto quick quota > 990 auto quick growfs > +991 auto growfs ioctl prealloc stress > -- > 2.27.0