From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: remove dead stale buf unpin handling code
Date: Wed, 12 May 2021 10:29:57 -0400 [thread overview]
Message-ID: <YJvmZRoEQRqMLd2I@bfoster> (raw)
In-Reply-To: <YJvDWUgZupjoW5Ib@infradead.org>
On Wed, May 12, 2021 at 01:00:25PM +0100, Christoph Hellwig wrote:
> > + ASSERT(list_empty(&lip->li_trans) && !bp->b_transp);
>
> Nit: Two separate ASSERTS are generally better than one with two
> conditions and a "&&", so that when the assert triggers it shows which
> condition caused it.
>
In this case both checks pretty much mean the same thing so I don't see
much added value, but I don't mind splitting it..
Brian
next prev parent reply other threads:[~2021-05-12 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 13:52 [PATCH 0/2] xfs: fix buffer use after free on unpin abort Brian Foster
2021-05-11 13:52 ` [PATCH 1/2] xfs: hold buffer across unpin and potential shutdown processing Brian Foster
2021-05-12 1:52 ` Darrick J. Wong
2021-05-12 12:22 ` Christoph Hellwig
2021-05-12 14:29 ` Brian Foster
2021-05-12 14:28 ` Brian Foster
2021-05-11 13:52 ` [PATCH 2/2] xfs: remove dead stale buf unpin handling code Brian Foster
2021-05-12 1:55 ` Darrick J. Wong
2021-05-12 12:00 ` Christoph Hellwig
2021-05-12 14:29 ` Brian Foster [this message]
2021-05-12 14:30 ` [PATCH v1.1 " Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJvmZRoEQRqMLd2I@bfoster \
--to=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox