[PATCH 20/23] xfs: inode allocation can use a single perag instance

Dave Chinner
2021-05-19T01:21:10Z

Now that we've internalised the two-phase inode allocation, we can
now easily make the AG selection and allocation atomic from the
perspective of a single perag context. This will ensure AGs going
offline/away cannot occur between the selection and allocation
steps.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
fs/xfs/libxfs/xfs_ialloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
index 8762836d0996..88c15d8bd6e4 100644
--- a/fs/xfs/libxfs/xfs_ialloc.c
+++ b/fs/xfs/libxfs/xfs_ialloc.c
@@ -1432,6 +1432,7 @@ static int
xfs_dialloc_ag(
struct xfs_trans *tp,
struct xfs_buf *agbp,
+ struct xfs_perag *pag,
xfs_ino_t parent,
xfs_ino_t *inop)
{
@@ -1446,7 +1447,6 @@ xfs_dialloc_ag(
int error;
int offset;
int i;
- struct xfs_perag *pag = agbp->b_pag;

if (!xfs_sb_version_hasfinobt(&mp->m_sb))
return xfs_dialloc_ag_inobt(tp, agbp, pag, parent, inop);
@@ -1760,9 +1760,9 @@ xfs_dialloc(
xfs_perag_put(pag);
return error ? error : -ENOSPC;
found_ag:
- xfs_perag_put(pag);
/* Allocate an inode in the found AG */
- error = xfs_dialloc_ag(*tpp, agbp, parent, &ino);
+ error = xfs_dialloc_ag(*tpp, agbp, pag, parent, &ino);
+ xfs_perag_put(pag);
if (error)
return error;
*new_ino = ino;
--
2.31.1