From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 23/23] xfs: remove xfs_perag_t
Date: Thu, 27 May 2021 07:20:34 -0400 [thread overview]
Message-ID: <YK+AgoWIHH8QgDIs@bfoster> (raw)
In-Reply-To: <20210519012102.450926-24-david@fromorbit.com>
On Wed, May 19, 2021 at 11:21:02AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Almost unused, gets rid of another typedef.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/libxfs/xfs_ag.c | 24 +++++++++++-----------
> fs/xfs/libxfs/xfs_ag.h | 4 ++--
> fs/xfs/libxfs/xfs_alloc.c | 42 +++++++++++++++++++--------------------
> 3 files changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 0e0819f6fb89..29c42698aa90 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -104,19 +104,19 @@ xfs_perag_put(
> */
> int
> xfs_initialize_perag_data(
> - struct xfs_mount *mp,
> - xfs_agnumber_t agcount)
> + struct xfs_mount *mp,
> + xfs_agnumber_t agcount)
> {
> - xfs_agnumber_t index;
> - xfs_perag_t *pag;
> - xfs_sb_t *sbp = &mp->m_sb;
> - uint64_t ifree = 0;
> - uint64_t ialloc = 0;
> - uint64_t bfree = 0;
> - uint64_t bfreelst = 0;
> - uint64_t btree = 0;
> - uint64_t fdblocks;
> - int error = 0;
> + xfs_agnumber_t index;
> + struct xfs_perag *pag;
> + struct xfs_sb *sbp = &mp->m_sb;
> + uint64_t ifree = 0;
> + uint64_t ialloc = 0;
> + uint64_t bfree = 0;
> + uint64_t bfreelst = 0;
> + uint64_t btree = 0;
> + uint64_t fdblocks;
> + int error = 0;
>
> for (index = 0; index < agcount; index++) {
> /*
> diff --git a/fs/xfs/libxfs/xfs_ag.h b/fs/xfs/libxfs/xfs_ag.h
> index bebbe1bfce27..39f6a0dc984a 100644
> --- a/fs/xfs/libxfs/xfs_ag.h
> +++ b/fs/xfs/libxfs/xfs_ag.h
> @@ -29,7 +29,7 @@ struct xfs_ag_resv {
> * Per-ag incore structure, copies of information in agf and agi, to improve the
> * performance of allocation group selection.
> */
> -typedef struct xfs_perag {
> +struct xfs_perag {
> struct xfs_mount *pag_mount; /* owner filesystem */
> xfs_agnumber_t pag_agno; /* AG this structure belongs to */
> atomic_t pag_ref; /* perag reference count */
> @@ -102,7 +102,7 @@ typedef struct xfs_perag {
> * or have some other means to control concurrency.
> */
> struct rhashtable pagi_unlinked_hash;
> -} xfs_perag_t;
> +};
>
> int xfs_initialize_perag(struct xfs_mount *mp, xfs_agnumber_t agcount,
> xfs_agnumber_t *maxagi);
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index f7864f33c1f0..00bb34251829 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -2694,21 +2694,21 @@ xfs_alloc_fix_freelist(
> * Get a block from the freelist.
> * Returns with the buffer for the block gotten.
> */
> -int /* error */
> +int
> xfs_alloc_get_freelist(
> - xfs_trans_t *tp, /* transaction pointer */
> - struct xfs_buf *agbp, /* buffer containing the agf structure */
> - xfs_agblock_t *bnop, /* block address retrieved from freelist */
> - int btreeblk) /* destination is a AGF btree */
> + struct xfs_trans *tp,
> + struct xfs_buf *agbp,
> + xfs_agblock_t *bnop,
> + int btreeblk)
> {
> - struct xfs_agf *agf = agbp->b_addr;
> - struct xfs_buf *agflbp;/* buffer for a.g. freelist structure */
> - xfs_agblock_t bno; /* block number returned */
> - __be32 *agfl_bno;
> - int error;
> - int logflags;
> - xfs_mount_t *mp = tp->t_mountp;
> - xfs_perag_t *pag; /* per allocation group data */
> + struct xfs_agf *agf = agbp->b_addr;
> + struct xfs_buf *agflbp;
> + xfs_agblock_t bno;
> + __be32 *agfl_bno;
> + int error;
> + int logflags;
> + struct xfs_mount *mp = tp->t_mountp;
> + struct xfs_perag *pag;
>
> /*
> * Freelist is empty, give up.
> @@ -2818,20 +2818,20 @@ xfs_alloc_pagf_init(
> /*
> * Put the block on the freelist for the allocation group.
> */
> -int /* error */
> +int
> xfs_alloc_put_freelist(
> - xfs_trans_t *tp, /* transaction pointer */
> - struct xfs_buf *agbp, /* buffer for a.g. freelist header */
> - struct xfs_buf *agflbp,/* buffer for a.g. free block array */
> - xfs_agblock_t bno, /* block being freed */
> - int btreeblk) /* block came from a AGF btree */
> + struct xfs_trans *tp,
> + struct xfs_buf *agbp,
> + struct xfs_buf *agflbp,
> + xfs_agblock_t bno,
> + int btreeblk)
> {
> struct xfs_mount *mp = tp->t_mountp;
> struct xfs_agf *agf = agbp->b_addr;
> - __be32 *blockp;/* pointer to array entry */
> + struct xfs_perag *pag;
> + __be32 *blockp;
> int error;
> int logflags;
> - xfs_perag_t *pag; /* per allocation group data */
> __be32 *agfl_bno;
> int startoff;
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-05-27 11:20 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 1:20 [PATCH 00/23] xfs: initial agnumber -> perag conversions for shrink Dave Chinner
2021-05-19 1:20 ` [PATCH 01/23] xfs: move xfs_perag_get/put to xfs_ag.[ch] Dave Chinner
2021-05-19 1:20 ` [PATCH 02/23] xfs: prepare for moving perag definitions and support to libxfs Dave Chinner
2021-05-26 12:33 ` Brian Foster
2021-05-27 22:02 ` Darrick J. Wong
2021-05-19 1:20 ` [PATCH 03/23] xfs: move perag structure and setup to libxfs/xfs_ag.[ch] Dave Chinner
2021-05-26 12:33 ` Brian Foster
2021-05-27 22:07 ` Darrick J. Wong
2021-05-19 1:20 ` [PATCH 04/23] xfs: make for_each_perag... a first class citizen Dave Chinner
2021-05-26 12:33 ` Brian Foster
2021-05-27 22:10 ` Darrick J. Wong
2021-05-19 1:20 ` [PATCH 05/23] xfs: convert raw ag walks to use for_each_perag Dave Chinner
2021-05-26 12:33 ` Brian Foster
2021-05-27 22:12 ` Darrick J. Wong
2021-05-19 1:20 ` [PATCH 06/23] xfs: convert xfs_iwalk to use perag references Dave Chinner
2021-05-27 22:16 ` Darrick J. Wong
2021-06-01 22:00 ` [PATCH 06/23 V2] " Dave Chinner
2021-06-01 23:32 ` Darrick J. Wong
2021-06-02 0:34 ` Dave Chinner
2021-05-19 1:20 ` [PATCH 07/23] xfs: convert secondary superblock walk to use perags Dave Chinner
2021-05-19 1:20 ` [PATCH 08/23] xfs: pass perags through to the busy extent code Dave Chinner
2021-05-19 1:20 ` [PATCH 09/23] xfs: push perags through the ag reservation callouts Dave Chinner
2021-05-26 12:34 ` Brian Foster
2021-05-19 1:20 ` [PATCH 10/23] xfs: pass perags around in fsmap data dev functions Dave Chinner
2021-05-27 22:19 ` Darrick J. Wong
2021-05-19 1:20 ` [PATCH 11/23] xfs: add a perag to the btree cursor Dave Chinner
2021-05-26 12:34 ` Brian Foster
2021-05-19 1:20 ` [PATCH 12/23] xfs: convert rmap btree cursor to using a perag Dave Chinner
2021-05-19 1:20 ` [PATCH 13/23] xfs: convert refcount btree cursor to use perags Dave Chinner
2021-05-27 22:22 ` Darrick J. Wong
2021-05-19 1:20 ` [PATCH 14/23] xfs: convert allocbt cursors " Dave Chinner
2021-05-19 1:20 ` [PATCH 15/23] xfs: use perag for ialloc btree cursors Dave Chinner
2021-05-19 1:20 ` [PATCH 16/23] xfs: remove agno from btree cursor Dave Chinner
2021-05-19 1:20 ` [PATCH 17/23] xfs: simplify xfs_dialloc_select_ag() return values Dave Chinner
2021-05-19 1:20 ` [PATCH 18/23] xfs: collapse AG selection for inode allocation Dave Chinner
2021-05-27 11:19 ` Brian Foster
2021-06-01 22:40 ` [PATCH 18/23 V2] " Dave Chinner
2021-06-01 23:27 ` Darrick J. Wong
2021-05-27 22:33 ` [PATCH 18/23] " Darrick J. Wong
2021-05-19 1:20 ` [PATCH 19/23] xfs: get rid of xfs_dir_ialloc() Dave Chinner
2021-05-19 1:20 ` [PATCH 20/23] xfs: inode allocation can use a single perag instance Dave Chinner
2021-05-19 1:21 ` [PATCH 21/23] xfs: clean up and simplify xfs_dialloc() Dave Chinner
2021-05-27 11:20 ` Brian Foster
2021-05-27 22:39 ` Darrick J. Wong
2021-05-19 1:21 ` [PATCH 22/23] xfs: use perag through unlink processing Dave Chinner
2021-05-27 11:20 ` Brian Foster
2021-05-19 1:21 ` [PATCH 23/23] xfs: remove xfs_perag_t Dave Chinner
2021-05-27 11:20 ` Brian Foster [this message]
2021-05-27 22:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK+AgoWIHH8QgDIs@bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).