From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com,
hch@infradead.org, bfoster@redhat.com
Subject: Re: [PATCH 03/16] xfs: detach dquots from inode if we don't need to inactivate it
Date: Wed, 16 Jun 2021 09:21:29 +0100 [thread overview]
Message-ID: <YMm0iY0WiMHa2B7s@infradead.org> (raw)
In-Reply-To: <162360481340.1530792.16718628800672012784.stgit@locust>
On Sun, Jun 13, 2021 at 10:20:13AM -0700, Darrick J. Wong wrote:
> - xfs_inactive(ip);
> + if (!need_inactive) {
> + /* Going straight to reclaim, so drop the dquots. */
> + xfs_qm_dqdetach(ip);
> + } else {
> + xfs_inactive(ip);
> + }
It seems like most of the checks contained in xfs_inode_needs_inactive
could be dropped from xfs_inactive now.
But given that I feel the heat already I'm not going to suggest that
now and just going to look into cleaning that up after the series
goes in..
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-06-16 8:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 17:19 [PATCHSET v7 00/16] xfs: deferred inode inactivation Darrick J. Wong
2021-06-13 17:20 ` [PATCH 01/16] xfs: refactor the inode recycling code Darrick J. Wong
2021-06-16 8:13 ` Christoph Hellwig
2021-06-13 17:20 ` [PATCH 02/16] xfs: move xfs_inactive call to xfs_inode_mark_reclaimable Darrick J. Wong
2021-06-16 8:18 ` Christoph Hellwig
2021-06-13 17:20 ` [PATCH 03/16] xfs: detach dquots from inode if we don't need to inactivate it Darrick J. Wong
2021-06-14 16:13 ` Brian Foster
2021-06-14 17:27 ` Darrick J. Wong
2021-06-16 8:21 ` Christoph Hellwig [this message]
2021-06-13 17:20 ` [PATCH 04/16] xfs: clean up xfs_inactive a little bit Darrick J. Wong
2021-06-14 16:14 ` Brian Foster
2021-06-14 17:34 ` Darrick J. Wong
2021-06-16 8:23 ` Christoph Hellwig
2021-06-13 17:20 ` [PATCH 05/16] xfs: separate primary inode selection criteria in xfs_iget_cache_hit Darrick J. Wong
2021-06-14 16:14 ` Brian Foster
2021-06-16 8:26 ` Christoph Hellwig
2021-06-13 17:20 ` [PATCH 06/16] xfs: defer inode inactivation to a workqueue Darrick J. Wong
2021-06-14 16:17 ` Brian Foster
2021-06-14 19:27 ` Darrick J. Wong
2021-06-15 14:43 ` Brian Foster
2021-06-15 20:53 ` Darrick J. Wong
2021-06-17 14:23 ` Brian Foster
2021-06-17 18:41 ` Darrick J. Wong
2021-06-18 14:00 ` Brian Foster
2021-06-18 14:58 ` Darrick J. Wong
2021-06-21 5:19 ` Christoph Hellwig
2021-06-13 17:20 ` [PATCH 07/16] xfs: drop dead dquots before scheduling inode for inactivation Darrick J. Wong
2021-06-13 17:20 ` [PATCH 08/16] xfs: expose sysfs knob to control inode inactivation delay Darrick J. Wong
2021-06-13 17:20 ` [PATCH 09/16] xfs: reduce inactivation delay when things are tight Darrick J. Wong
2021-06-13 17:20 ` [PATCH 10/16] xfs: inactivate inodes any time we try to free speculative preallocations Darrick J. Wong
2021-06-13 17:20 ` [PATCH 11/16] xfs: flush inode inactivation work when compiling usage statistics Darrick J. Wong
2021-06-13 17:21 ` [PATCH 12/16] xfs: parallelize inode inactivation Darrick J. Wong
2021-06-13 17:21 ` [PATCH 13/16] xfs: don't run speculative preallocation gc when fs is frozen Darrick J. Wong
2021-06-13 17:21 ` [PATCH 14/16] xfs: scale speculative preallocation gc delay based on free space Darrick J. Wong
2021-06-13 17:21 ` [PATCH 15/16] xfs: use background worker pool when transactions can't get " Darrick J. Wong
2021-06-13 17:21 ` [PATCH 16/16] xfs: avoid buffer deadlocks when walking fs inodes Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMm0iY0WiMHa2B7s@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox