Re: [PATCH 5/8] xfs: factor out log write ordering from xlog_cil_push_work()

Dave Chinner
2021-06-18T22:34:38Z

On Fri, Jun 18, 2021 at 03:27:49PM +0100, Christoph Hellwig wrote:
> On Thu, Jun 17, 2021 at 12:59:04PM -0700, Darrick J. Wong wrote:
> > On Thu, Jun 17, 2021 at 06:26:14PM +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > So we can use it for start record ordering as well as commit record
> > > ordering in future.
> > >
> > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> >
> > This tricked me for a second until I realized that xlog_cil_order_write
> > is the chunk of code just prior to the xlog_cil_write_commit_record
> > call.
>
> Yeah, moving the caller at the same time as the factoring is a trick
> test for every reader. I think this needs to be documented in the
> commit log. Or even better moved to a separate log, but it seems you
> get shot for that kind of suggestion on the xfs list these days..

Sorry, what? This should be a straight factoring - the place we do
the ordering check must not change because that'll break shit.

Ngggh.

Yeah, thanks git. When I rebased the patch, it's merged the hunk
into the wrong place. It gets fixed up later when I move the ordering
inside the xlog_cil_write_commit_record() function, but this patch
by itself was silently broken by the tooling.

-Dave.
--
Dave Chinner
david@fromorbit.com